"Hide empty staves" hides non-empty staves when first measure is empty

• Nov 10, 2018 - 18:13
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project

Hide empty staves seems to now consider a staff empty if the first measure on a system is empty, even other measures have notes. Try turning that option on for the attached file. You'll see staves disappearing that should not.

Attachment Size
hide-empty.mscz 12.69 KB

Comments

This issue seems to be caused by Werners commit here: https://github.com/musescore/MuseScore/commit/9c8ca0fdb488074313fa2112b…
Now only the first measure of every system has been appended to the measureBase list. So checks are only made on first measure of a staff.
I can't figure out an easy solution for this problem. It makes most sense to revert the changes and check after a system is collected as before. One can only be sure if a staff should be hidden after the system is complete.

Priority P1 - High P0 - Critical
Severity S3 - Major S2 - Critical

I don't suppose there is any chance of this being fixed for beta? I guess I should have marked it P0, S2 to begin with, it's really a showstopper.

Title "Hide empty staves" hides non-empty staves "Hide empty staves" hides all systems when first measure is empty

Changed the name so it makes more sense.

Title "Hide empty staves" hides all systems when first measure is empty "Hide empty staves" hides non-empty staves when first measure is empty

No doubt my original title wasn't good, but I think it needed further improvement

Status PR created fixed

Fixed in branch master, commit e65488af67

fix #278057, fix #277666: hide empty staves reusing space for instrument names

The previous fix 9c8ca0fdb488074313fa2112b02ee37edd05497c
caused a side-effect of hiding non-empty staves if their first
measure was empty.