Parentheses (from Master palette > Symbols) reset to default positions or lost altogether
Reported version
3.0
Priority
P1 - High
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
Win 10 / MS 3.0.0, 32c4c4c
Open the attached file (created in MS2). Take the reset option offered. This is a snapshot from MS 2:
Compare it the same view in 3.0-dev:
The first parenthesis has disappeared altogether. The other parentheses have been reset to the default position.
Attachment | Size |
---|---|
symbols_master_palette.mscz | 12.76 KB |
Comments
The parentheses being reset to their default positions isn't a bug, that is expected behaviour. The one parenthesis disappearing isn't expected behaviour, however. I'll investigate that.
Right, this is more complex than I thought it would be. I won't pursue this, but here's what I've found for anyone else looking at this:
I have no idea why they aren't drawn. This is one for someone else to figure out :)
I'm also upgrading this to S2, I think it counts as data loss.
See https://github.com/musescore/MuseScore/pull/4243
Concerning default positions of brackets, yes, as these brackets are merely symbols common rules for symbols layout are applied for them which results in such layout in this case. There are some special rules regarding notehead brackets but there are a lot of different kinds of symbols and for most of them no special layout rules are defined. Maybe we should consider not resetting positions for symbols when importing scores as they anyway have to be positioned manually. Or at least make this "reset positions" command accessible via a regular menu action ("Reset shapes and positions" does a bit more than that) so that user can choose which positions to reset via selection.
Well, at least symbols should not disappear now.
Great! So really, what was happening was that they weren't being layed out, because the code to do that had been left commented out by Werner? (i.e. the commented out code below your changes)
In fact, yes. If that code was uncommented we would still experience the same kind of issues in excerpts though.
Fixed in branch master, commit 85551d8f18
fix #278039: layout symbols attached to segments
Fixed in branch master, commit bf05b50864
Merge pull request #4243 from dmitrio95/278039-layout-segment-symbol
fix #278039: layout symbols attached to segments
Automatically closed -- issue fixed for 2 weeks with no activity.