Ambitus not correctly calculated for (octave) transposing instruments
Reported version
3.0
Type
Functional
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
Yes
Project
when adding an ambitus for a b-instrument (in my case: Alt-sax), the lower limit is always wrong calculated (sometimes also the upper).
If I switch to concert pitch, calculation seems to be ok. But when I then switch back to normal, the ambitus range is not re-calculated but stays in the concert range.
This applies to V3 as well as to V2-versions.
Fix version
3.5.1
Comments
Came up again in https://musescore.org/de/node/300376
Happens for octave transposing instruments too, for example piccolo or contrabass. Not sure whether they're the same cause though.
Plural of Ambitus is Ambitus
Transposing is transposing, no matter whether octave or any other interval. But see also #305941: Changing octaves for ambiti doesn't work correctly, allegedly fixed in 3.5
I don't see a workaround, nor a reason for the issue being major
The redraw issue mentioned in the initial post seems to be fixed too in 3.5, see #284344: Ambitus not redrawn on Update Range
The code in
void Ambitus::updateRange()
usesppitch()
, the playback pitch, probably should useepitch()
, the effective pitch.Actually I can reproduce the issue only for octave transposing instruments!?!
The above mentioned change seems to fix that though (and doesn't break other cases as far as I can tell)
And for any transposing instruments the ambitus does not update when changing to/from concert pitch.
Maybe
Ambitus::updateRange()
needs to get called on toggling concert pitchFunny enough I can get the updating on toggling concert pith to work, but not for octave transposing (see #309371: Ambitus for transposing instruments doesn't update when toggling concert pitch)
Those BTW don't report different pitches in the status bar (e.g. "Pitch: A4 (concert A5)") (see #309369: status bar does not show concert pitch of octave transposing instruments)
see https://github.com/musescore/MuseScore/pull/6476
Major because this is a core functionality of ambitus (isn't it ambiti then, if "es" is not allowed?) and it isn't working. Workaround is to manually update the range in the inspector.
I can reproduce for alto sax, for example C#4 to A4 in A major, written pitch.
(See https://en.m.wiktionary.org/wiki/ambitus, it's ambituses or ambiti)
OK, I can reproduce for Alto Sax, but not for Bb Clarinet.
But my PR fixes that too
In reply to OK, I can reproduce for Alto… by Jojo-Schmitz
Bb Clarinet has the issue too, for example D4 to C#5 in D major, written pitch.
confirmed, very strange, but too fixed with this PR
(no plural in German: https://de.m.wiktionary.org/wiki/Ambitus, nor in Latin, so esp. not Ambitii, if anything then Ambituus)
Fixed in branch 3.x, commit 6140370a06
fix #284357: Ambitus not correctly calculated for (octave) transposing instruments
Fixed in branch 3.x, commit aec5a62154
_Merge pull request #6476 from Jojo-Schmitz/ambitus-transposing
fix #284357: Ambitus not correctly calculated for (octave) transposing instruments_
Fixed in branch master, commit d84269bee6
fix #284357: Ambitus not correctly calculated for (octave) transposing instruments
Automatically closed -- issue fixed for 2 weeks with no activity.