Hairpin automatially offset vertically below dynamic instead of aligning

• Aug 15, 2016 - 16:37
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project

1. 99dde41, My_First_Score.
2. Format > Add/Remove Line Breaks, Remove current line breaks, OK.
3. Enter four quarter notes into first measure.
4. Select first three notes, add hairpin.
5. Add two- or three-letter dynamic to last note.

Expected result:
hairpin-dynamic1.png
Actual result:
hairpin-dynamic2.png


Comments

Severity S3 - Major S2 - Critical
Frequency Once
Priority P0 - Critical
Regression No
Reproducibility Always
Workaround No

Current situation is even worse, but should be addressed in MuseScore 3 Beta anyway.

Status PR created fixed

Fixed in branch master, commit 5165150de6

fix #121431: fit hairpins between adjacent dynamics

Adjusts horizontal dimensions of hairpins to fit between adjacent
dynamics, if any exist. No vertical aligning included, as it is
already available in the form of begin/end text for hairpins.
Still for some common cases the logic added by this commit is
good enough.

Dimensions calculation code is taken (with some adjustments) from
8bdd1af0bef02353f46df53107a4472bfb04f98a

Also includes:
- Rename/update Segment::findAnnotation[orElement]
- Add Score::isPalette() to make it easier to distinguish between
palette and normal scores on layout stage.