some template files don't define ranges for the instruments they use
Type
Functional
Severity
S5 - Suggestion
Status
active
Regression
No
Workaround
No
Project
Rather than defining a reasonable range for the instruments (taken from e.g. instruments.xml) used in several templates, ranges from 0-127 are used, preventing the colouring of out-or-range notes to happen.
I haven't yet checked them all (none of the mscz files), but certainly Choir SATB.mscx, Choir SAT witk Piano.mscx, Piano.mscx
If there is consensus that having range settings in these templates is a good thing, I'd volunter to take care of this.
At the same time I'd like to change the few tempates in mscz format to mscx format, given that the resulting files are still quite small, but mscx files, being plain text, are better suited for revision control.
Comments
Well actually I'm currently engaged in updating the templates to comply with 2.0 compatibility, so this would be a complementary thing..
I've come to a grinding halt atm though while I wait for the dev team to fix template parsing problems to do with transposing instruments.
I've just now submited a pull request with all templates changed to .mscx format, as a 1st step.
How did you do that?
If you resaved them from 1.2 then you've just duplicated what I have done!
unpacked the mscz with 7-zip
:)
Ranges now defined in the SATB templates.
I shall address this with any others when I get to them.
As soon as Werner confirms there will be no changes to the file format before the next stable release I will sned in the pull request.
Info update:
Still waiting on confirmation of no further file format changes.
Do you know where the pull request for this is, @Jojo-Schmitz?
No, there is none as far as I can tell, I guess @ChurchOrganist never submitted one, pending information about file format change