Left Hand Page Margin fixed at 10mm, if changed via Page Settings, the difference gets added to Right Margin ericfontainejazz • Mar 16, 2017 - 04:23 Reported version 3.0 Type Functional Severity S4 - Minor Status closed Project MuseScore affects 3.0-dev bd894bd8d but not 2.1 Reply Comments ericfontainejazz • Mar 16, 2017 - 07:26 I think I see what is happening. Reply ericfontainejazz • Mar 16, 2017 - 07:31 I'm also noticing PageSettings::elmChanged() is the only function which uses: double f = mmUnit ? 1.0/INCH : 1.0; val *= f; while all the other ones simply do: if (mmUnit) val /= INCH; I'm pretty sure it should be like the others...(maybe it doesn't matter...but the code is easier to read then anyways). Reply ericfontainejazz • Mar 16, 2017 - 08:23 hmm...maybe I'm #2 is there for a reason since there is no such thing as StyleIdx::pageEvenRightMargin Reply ericfontainejazz • Mar 16, 2017 - 08:50 If set both left and right margins to 0 for both odd and even, then interestingly the staff traverses over the page boundary: Reply ericfontainejazz • Mar 16, 2017 - 08:52 in that above screenshot, notice that the 2nd page (even) has both margins correct. I've determined that this bug is specific to the Odd pages left margin only. Reply ericfontainejazz • Mar 16, 2017 - 09:05 aha. PageSettings::applyToScore() was not actually applying to Odd Left Margin! Reply ericfontainejazz • Mar 16, 2017 - 09:12 Status (old) active ⇒ patch (code needs review) easy fix: https://github.com/musescore/MuseScore/pull/3074 Reply Git Message • Mar 16, 2017 - 10:30 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 347e3bf19b fix #181696 Apply Page Settings to Odd Left Margin too! Clearly this line was neglected. Reply Git Message • Mar 16, 2017 - 10:30 Fixed in branch master, commit de4840c34b Merge pull request #3074 from ericfont/181696-ApplyPageSettingsEvenLeftMargin fix #181696 Apply Page Settings Odd Left Margin too! Reply System Message • Mar 30, 2017 - 11:35 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
ericfontainejazz • Mar 16, 2017 - 07:31 I'm also noticing PageSettings::elmChanged() is the only function which uses: double f = mmUnit ? 1.0/INCH : 1.0; val *= f; while all the other ones simply do: if (mmUnit) val /= INCH; I'm pretty sure it should be like the others...(maybe it doesn't matter...but the code is easier to read then anyways). Reply
ericfontainejazz • Mar 16, 2017 - 08:23 hmm...maybe I'm #2 is there for a reason since there is no such thing as StyleIdx::pageEvenRightMargin Reply
ericfontainejazz • Mar 16, 2017 - 08:50 If set both left and right margins to 0 for both odd and even, then interestingly the staff traverses over the page boundary: Reply
ericfontainejazz • Mar 16, 2017 - 08:52 in that above screenshot, notice that the 2nd page (even) has both margins correct. I've determined that this bug is specific to the Odd pages left margin only. Reply
ericfontainejazz • Mar 16, 2017 - 09:05 aha. PageSettings::applyToScore() was not actually applying to Odd Left Margin! Reply
ericfontainejazz • Mar 16, 2017 - 09:12 Status (old) active ⇒ patch (code needs review) easy fix: https://github.com/musescore/MuseScore/pull/3074 Reply
Git Message • Mar 16, 2017 - 10:30 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 347e3bf19b fix #181696 Apply Page Settings to Odd Left Margin too! Clearly this line was neglected. Reply
Git Message • Mar 16, 2017 - 10:30 Fixed in branch master, commit de4840c34b Merge pull request #3074 from ericfont/181696-ApplyPageSettingsEvenLeftMargin fix #181696 Apply Page Settings Odd Left Margin too! Reply
System Message • Mar 30, 2017 - 11:35 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
I think I see what is happening.
I'm also noticing PageSettings::elmChanged() is the only function which uses:
double f = mmUnit ? 1.0/INCH : 1.0; val *= f;while all the other ones simply do:
if (mmUnit) val /= INCH;I'm pretty sure it should be like the others...(maybe it doesn't matter...but the code is easier to read then anyways).
hmm...maybe I'm #2 is there for a reason since there is no such thing as StyleIdx::pageEvenRightMargin
If set both left and right margins to 0 for both odd and even, then interestingly the staff traverses over the page boundary:
in that above screenshot, notice that the 2nd page (even) has both margins correct. I've determined that this bug is specific to the Odd pages left margin only.
aha. PageSettings::applyToScore() was not actually applying to Odd Left Margin!
easy fix: https://github.com/musescore/MuseScore/pull/3074
Fixed in branch master, commit 347e3bf19b
fix #181696 Apply Page Settings to Odd Left Margin too!
Clearly this line was neglected.
Fixed in branch master, commit de4840c34b
Merge pull request #3074 from ericfont/181696-ApplyPageSettingsEvenLeftMargin
fix #181696 Apply Page Settings Odd Left Margin too!
Automatically closed -- issue fixed for 2 weeks with no activity.