Accidental does not move with manual adjustment to note/chord

• May 6, 2014 - 03:15
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Windows 7, GIT commit: d8b325d

1) new score
2) add note with accidental
3) click notehead
4) move chord or element (notehead) using Inspector

Result: accidental does not move

I guess it's debatable whether it should, but it did in 1.3, and in the use cases I can think of, it is usually desirable.

Comments

• May 6, 2014 - 12:36

If you move the notehead vertical the accidental does also move.
The horizontal position of an accidental does not directly depend on the note head position. It depends also on other elements. If you think of a chord with several accidentals i believe its not desirable to move only one accidental with the corresponding note head.

Reply

• May 6, 2014 - 14:36

Yes, there is not going to be one right answer for all cases, I fear.

The case I am most concerned about is if you move the entire chord. Or, in the case of single-note chords, moving the only note, which normally has the effect of moving the chord. I am less concerned about moving individual notes within a chord.

So if you move an entire chord, it does seem all of its accidentals should move with it. But even that is problematic because that could affect accidentals on chords in other voices on the same staff.

Right now, layout for all accidentals for all voices is computed from a common origin point - the left-most note in any chord (not counting mirrored downstem notes, which are allowed to extend to the left that origin if they don't conflict with accidentals). The implementation I had in mind simply takes user offsets into account in computing this origin. So all accidentals continue to be at the same position relative to each other. If you move notes or chords in a way that changes the location of left-most note, all accidentals would move together.

Whether this is a good thing or not depends on why you are moving the notes or chords in the first place. My hope, of course, is that the need for moving things around is greatly lessened compared to 1.3

Reply

• May 10, 2014 - 15:41
Status (old) fixed ⇒ active

I had committed a fix but backed it out in a later commit after this discussion.

I'm still on the fence about this. I will ask for feedback in forum.

Reply

• May 20, 2014 - 01:05

It's actually worse than this. Create a chord of two notes, put an accidental on one note, then move that note left 1sp. Accidental overlaps the moved heard, as currently expected. Now save and reload. The accidental no longer overlaps the note. But then press Ctrl+A and things return to the way they were when you saved. This is a bug that I need to be fix.

My plan is to make it so moving the *chord* will move the accidental stack, but moving individual notes will not. I may change my mind and allow moving individual notes to also move the stack. But Werner is definitely right - moving individual notes should note move individual accidentals.

Reply