Issue during creating horizontal frame

• Dec 15, 2015 - 18:39
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Fine; when i try to create an HORIZONTAL FRAME at the end of a system, and in the beginning of the next system exist various empty measures (multi-rest measure), MuseScore shows that measure as a single empty measure and even a no-line!!! measure if the multi-rest mode is enabled.

I made a video with that: https://youtu.be/RuQsWYLTjXY

GIT commit: 3543170

Comments

• Dec 15, 2015 - 18:53

Could you post the specific score you are having problems with and precise steps to reproduce the problem?

Also, for future reference, please leave the Assigned field blank - that is meant to indicate the programmer who will fix a problem, not the user who reported it.

Reply

• Dec 15, 2015 - 19:01

Yeah.. I forgot the file...

The way is specified in the video. In my file, You should move to thebegginning of the second system in the second page, in order to create the frame just at the end of the first system, and then you will see the issue after creating that frame.

Attachment Size
Merenmix Cálido (Trombone).mscz 31.41 KB

Reply

• Dec 15, 2015 - 19:03

Yeah.. I forgot the file...

The way is specified in the video. In my file, You should move to the begginning of the second system in the second page, in order to create the frame just at the end of the first system, and then you will see the issue after creating that frame.

Attachment Size
Merenmix Cálido (Trombone).mscz 31.41 KB

Reply

• Dec 22, 2015 - 01:11

I am investigating this and have figured out how to fix it, but have encountered another issue in the same area of code while testing my fix. Can someone please verify the following:

1) My First Score
2) Right click a line break
3) Select / All Similar Elements
4) Delete
5) Click measure 15 to select
6) Insert horizontal frame
7) Re-select measure 15
8) Insert horizontal frame (resulting in two consecutive horizontal frames)
9) Double click first horizontal frame
10) Press right arrow to increase its size until measure 15 is pushed to next system

Result on 2.0.2: measure 15 is pushed to second system, first system is stretched normally
Result in current builds: measure 15 is pushed to second system, but first system is left unstretched. If you try to save the score at this point then re-load it, you get a crash.

I suspect I broke this, although I know other have tocuhed this code as well. Can anyone say more about when this problem was introduced?

Reply

• Dec 22, 2015 - 04:42

No sure at all. It occurs in October 28. I continue to bring me closer.
Many commits this day.

EDIT:
- Works with this Nightly: ef9e6ba
Result, as expected:
28 octobre first.jpg
- Not with this one: 38b9d51
Result:
28 octobre 38b9d next.jpg
So, maybe this last and same mentionned commit/nightly is involved? https://github.com/musescore/MuseScore/commit/38b9d51ff482246845dd61c2e….
Not sure at all, so, I continue to check "around" these two commits (except if confirmation?)

EDIT1:

Or, the immediate previous commit? https://github.com/musescore/MuseScore/commit/c4c3f1c8c8245984d710942b5…
Other (less likely) ? https://github.com/musescore/MuseScore/commit/b8c1fe0e61e29ac23367e7537…
And a last one (I hope!) : https://github.com/musescore/MuseScore/pull/2223/files

Reply

• Dec 22, 2015 - 19:08
Status (old) active ⇒ patch (code needs review)

https://github.com/musescore/MuseScore/pull/2322

This fixes the original issue. I submitted the additional probldem decribed in #5 as #91471: Crash on load of score with horizontal frame taking an entire system so it can be considered spearately.

BTW, a workaround for the original issue: add a line break at the end of the line. Whether you add it to the last measure of the line or to the horizontal frame, the multimeasure rest on the next line will display properly. The problem occurs only in cases where there is a horizontal frame at the end of one system and a multimeasure rest at the start of the next, and there is no explicit line break on the horizontal frame.

Reply