REGRESSION: Preferences | Shortcuts: Detection of conflicts ignores shortcut states
Context: commit 6e47f7 (tag "v2.0.0") self-compiled with Qt Lib 5.3 and Qt Creator 3.3.0 under Linux Mint 17 64-bit.
Description:
- Open the "Edit | Preferences..." dialogue box, tab "Shortcuts"
- Select the list item "Enter Note G" and press [Define]
- Press the key [J] as new short-cut
Result:
Error message " Shortcut conflicts with Add fret 8 of current string (TAB only)".
However, "Enter Note G" and "Add fret 8 of current string (TAB only)" short-cuts have different, non-overlapping states, so there is no actual conflict.
Note:
This is probably due to the commit https://github.com/musescore/MuseScore/commit/2ab813d69f1d634cdc02cde54… which removed the state check from conflict detection.
Apparently this was while enabling short-cuts for plug-in activation. Is this really necessary? Because, the functionality of the short-cut remapper is now greatly reduced.
Comments
PR pushed to github: https://github.com/musescore/MuseScore/pull/1912
Fixed in 210dc84443
Automatically closed -- issue fixed for 2 weeks with no activity.