"Tab bar" in View menu on macOS Sierra

Isaac Weiss

• Feb 7, 2018 - 16:39

Reported version

2.2

Type

Functional

Severity

S4 - Minor

Status

closed

Project

MuseScore

In 2.1 release and 2.2 nightly 3f4efd8, on macOS 10.12 Sierra (and probably also 10.13 High Sierra), the option "Show/Hide Tab Bar" appears at the top of the View menu. This is a new feature in macOS that allows programs that open documents in separate windows (which is something I'd like in MuseScore, but that's another topic) to combine them into a single tabbed window, but since MuseScore already uses a single tabbed window with its own row of tabs, we should prevent this extra menu command from being added.

From https://developer.apple.com/library/content/releasenotes/AppKit/RN-AppK…

"What should an application which already has support for tabbing do? - The application should explicitly opt-out of automatic window tabbing by calling [NSWindow setAllowsAutomaticWindowTabbing:NO]."

Comments

[DELETED] 5

• Feb 8, 2018 - 08:28

The relevant Qt bug https://bugreports.qt.io/browse/QTBUG-61707

[DELETED] 5

• Feb 8, 2018 - 09:16

and discussion https://forum.qt.io/topic/82609/remove-native-mac-menu-items-such-as-sh…

mattmcclinch

• Feb 9, 2018 - 15:59

Status (old)	active	⇒	patch (code needs review)
Status	active	⇒
Reported version	2.1	⇒	2.2

See fix #269212: "Tab bar" in View menu on macOS Sierra.

Jojo-Schmitz

• Feb 9, 2018 - 16:24

As per that Qt Bug report, Qt 5.9 is affected to, so our master branch should be affected too, or is it not?

mattmcclinch

• Feb 9, 2018 - 16:29

Yes, the master branch is affected as well. I can submit a pull request for master also, if that would be helpful. But I knew that we were trying to get 2.2 ready for release.

mattmcclinch

• Feb 9, 2018 - 17:54

And here is a pull request for the master branch.

Git Message

• Feb 12, 2018 - 10:34