[MusicXML import] use lyric number as relative instead of as absolute line number Leon Vinken • Oct 1, 2017 - 12:09 Reported version 2.1 Type Functional Severity S4 - Minor Status closed Project MuseScore See https://musescore.org/en/node/253721. Reply Comments Jojo-Schmitz • Oct 1, 2017 - 12:15 Reported version 3.0 ⇒ 2.1 The bug is actually in 2.x too, and a fix should be made of 2.2 and master Reply Leon Vinken • Oct 1, 2017 - 12:38 In reply to The bug is actually in 2.x… by Jojo-Schmitz Sure, but according to the normal process, I'll fix it in 3.0 and have it cherry-picked for 2.x. Reply Leon Vinken • Oct 3, 2017 - 06:36 Fix implemented (works), will also do a little bit of refactoring and add one or more testfiles. Reply Leon Vinken • Oct 4, 2017 - 19:01 Status (old) active ⇒ patch (ready to commit) Status active ⇒ PR created Pull request 3306 Reply Jojo-Schmitz • Jan 14, 2018 - 08:55 Status (old) patch (ready to commit) ⇒ patch (code needs review) Status PR created ⇒ Or https://github.com/musescore/MuseScore/pull/3306 This needs a rebase Reply Jojo-Schmitz • Mar 3, 2018 - 08:21 Status (old) patch (code needs review) ⇒ active Status ⇒ active PR got rejected Reply Leon Vinken • Mar 3, 2018 - 18:51 Unfortunately, my previous solution in PR 3306 is indeed incorrect (it breaks lyrics extension lines), so I have to find another solution. Reply Leon Vinken • Mar 5, 2018 - 07:05 Solution found, implementation in progress. Reply Jojo-Schmitz • Mar 10, 2018 - 10:23 Status (old) active ⇒ patch (code needs review) Status active ⇒ https://github.com/musescore/MuseScore/pull/3530 Reply Git Message • Mar 10, 2018 - 13:40 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch master, commit fdc0549cc9 fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number Reply Git Message • Mar 10, 2018 - 13:40 Fixed in branch master, commit 422efca1ad Merge pull request #3530 from lvinken/255791-musicxml-relative-lyric-numbers-3 fix #255791 - [MusicXML import] use lyric number as relative instead … Reply Jojo-Schmitz • Mar 10, 2018 - 13:52 Status (old) fixed ⇒ patch (code needs review) Status fixed ⇒ reopen for 2.2, see https://github.com/musescore/MuseScore/pull/3531 Reply Leon Vinken • Mar 11, 2018 - 07:59 In reply to reopen for 2.2 by Jojo-Schmitz Fix in master indeed should also be merged into 2.2. Reply Jojo-Schmitz • Mar 11, 2018 - 08:39 Currently there's an mtest failure though, see https://travis-ci.org/musescore/MuseScore/jobs/351818974#L4960-L4981 Edit: it just got fixed Reply Git Message • Mar 12, 2018 - 10:02 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch 2.2, commit c6c817e67c fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number Reply Git Message • Mar 12, 2018 - 10:02 Fixed in branch 2.2, commit 0628bff99b Merge pull request #3531 from lasconic/255791-musicxml-relative-lyric-numbers-22 fix #255791 - [MusicXML import] use lyric number as relative instead … Reply System Message • Mar 27, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Oct 1, 2017 - 12:15 Reported version 3.0 ⇒ 2.1 The bug is actually in 2.x too, and a fix should be made of 2.2 and master Reply
Leon Vinken • Oct 1, 2017 - 12:38 In reply to The bug is actually in 2.x… by Jojo-Schmitz Sure, but according to the normal process, I'll fix it in 3.0 and have it cherry-picked for 2.x. Reply
Leon Vinken • Oct 3, 2017 - 06:36 Fix implemented (works), will also do a little bit of refactoring and add one or more testfiles. Reply
Leon Vinken • Oct 4, 2017 - 19:01 Status (old) active ⇒ patch (ready to commit) Status active ⇒ PR created Pull request 3306 Reply
Jojo-Schmitz • Jan 14, 2018 - 08:55 Status (old) patch (ready to commit) ⇒ patch (code needs review) Status PR created ⇒ Or https://github.com/musescore/MuseScore/pull/3306 This needs a rebase Reply
Jojo-Schmitz • Mar 3, 2018 - 08:21 Status (old) patch (code needs review) ⇒ active Status ⇒ active PR got rejected Reply
Leon Vinken • Mar 3, 2018 - 18:51 Unfortunately, my previous solution in PR 3306 is indeed incorrect (it breaks lyrics extension lines), so I have to find another solution. Reply
Jojo-Schmitz • Mar 10, 2018 - 10:23 Status (old) active ⇒ patch (code needs review) Status active ⇒ https://github.com/musescore/MuseScore/pull/3530 Reply
Git Message • Mar 10, 2018 - 13:40 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch master, commit fdc0549cc9 fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number Reply
Git Message • Mar 10, 2018 - 13:40 Fixed in branch master, commit 422efca1ad Merge pull request #3530 from lvinken/255791-musicxml-relative-lyric-numbers-3 fix #255791 - [MusicXML import] use lyric number as relative instead … Reply
Jojo-Schmitz • Mar 10, 2018 - 13:52 Status (old) fixed ⇒ patch (code needs review) Status fixed ⇒ reopen for 2.2, see https://github.com/musescore/MuseScore/pull/3531 Reply
Leon Vinken • Mar 11, 2018 - 07:59 In reply to reopen for 2.2 by Jojo-Schmitz Fix in master indeed should also be merged into 2.2. Reply
Jojo-Schmitz • Mar 11, 2018 - 08:39 Currently there's an mtest failure though, see https://travis-ci.org/musescore/MuseScore/jobs/351818974#L4960-L4981 Edit: it just got fixed Reply
Git Message • Mar 12, 2018 - 10:02 Status (old) patch (code needs review) ⇒ fixed Status ⇒ fixed Fixed in branch 2.2, commit c6c817e67c fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number Reply
Git Message • Mar 12, 2018 - 10:02 Fixed in branch 2.2, commit 0628bff99b Merge pull request #3531 from lasconic/255791-musicxml-relative-lyric-numbers-22 fix #255791 - [MusicXML import] use lyric number as relative instead … Reply
System Message • Mar 27, 2018 - 10:00 Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
The bug is actually in 2.x too, and a fix should be made of 2.2 and master
In reply to The bug is actually in 2.x… by Jojo-Schmitz
Sure, but according to the normal process, I'll fix it in 3.0 and have it cherry-picked for 2.x.
Fix implemented (works), will also do a little bit of refactoring and add one or more testfiles.
Pull request 3306
Or https://github.com/musescore/MuseScore/pull/3306
This needs a rebase
PR got rejected
Unfortunately, my previous solution in PR 3306 is indeed incorrect (it breaks lyrics extension lines), so I have to find another solution.
Solution found, implementation in progress.
https://github.com/musescore/MuseScore/pull/3530
Fixed in branch master, commit fdc0549cc9
fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number
Fixed in branch master, commit 422efca1ad
Merge pull request #3530 from lvinken/255791-musicxml-relative-lyric-numbers-3
fix #255791 - [MusicXML import] use lyric number as relative instead …
reopen for 2.2, see https://github.com/musescore/MuseScore/pull/3531
In reply to reopen for 2.2 by Jojo-Schmitz
Fix in master indeed should also be merged into 2.2.
Currently there's an mtest failure though, see https://travis-ci.org/musescore/MuseScore/jobs/351818974#L4960-L4981
Edit: it just got fixed
Fixed in branch 2.2, commit c6c817e67c
fix #255791 - [MusicXML import] use lyric number as relative instead of as absolute line number
Fixed in branch 2.2, commit 0628bff99b
Merge pull request #3531 from lasconic/255791-musicxml-relative-lyric-numbers-22
fix #255791 - [MusicXML import] use lyric number as relative instead …
Automatically closed -- issue fixed for 2 weeks with no activity.