GSoC 2019: Plugin Manager (Week 10)
In this week, a few improvements are added:
-
Disable the "Uninstall" button when updating plugins, because the operation may cause crashes.
-
Add "OK" and "Cancel" buttons. So the plugin manager tab's UI is completely the same as the old (and removed) one now. Those buttons are placed only in the plugin manager tab at the right bottom. As before, the "Cancel" button, the close button abandon current changes in Plugin Manager, and the "OK" button accepts them.
What to do next
I'm still doing research in 2.x plugins and find possibilities to provide an option to download/convert them too. Though I have no idea whether there's a chance to make a stable implementation and integrate it into the PR, we can be free and easy because other features are not affected.
Also, I find there're some TODO items still left in my code which show potential optimization space in plugin download process.
In the next week or two, I'm looking forward to making everything ready for code review and get this finished:)
See you all next week!
Comments
Make sure to use a QDialogButtonBox rather than independent Ok and Cancel buttons, this is easier with the different default orders between Windows, macOS and Linux
In reply to Make sure to use a… by Jojo-Schmitz
Yep, I've implemented that way.
In reply to Yep, I've implemented that… by songchao
Thanks ;-)
I have not been following GSoC closely, but please ensure that the manager bug whereby "reload plugins" loses your plugin accelerators is fixed. "Reload just this plugin" would be nice too. Thank you.
In reply to I have not been following… by [DELETED] 1831606
"Reload just this plugin" is possible to me and I may consider it :)
What do you mean by "plugin accelerator"?
In reply to "Reload just this plugin" is… by songchao
Shortcut
In reply to Shortcut by Ziya Mete Demircan
As Jojo says, Thanks ;-)
In reply to "Reload just this plugin" is… by songchao
It should be fixed by this commit: https://github.com/musescore/MuseScore/pull/4833/commits/e817635690051d…
In reply to It should be fixed by this… by songchao
Thank you!