Remove carat from Find (Ctrl-F) function
The Find (Ctrl-F) function text field shows a carat which is not hooked up to any functionality.
The issue:
It confuses users as one may expect see either a list of previous search terms, or a search selection (e.g. page, bar or rehearsal mark).
Possible solution is to remove the carat.
Cheers,
Dave
Attachment | Size |
---|---|
Find.jpg | 2.79 KB |
Comments
maybe one day it will be populated? eg:
Yes, which I prefer, personally.
I think it helps from a usability perspective to visually guide the user how to use certain functions.
In other words, one should be able to use the Find function without prior knowledge of a pprefix to find e.g. a page. So it may become something similar to Word's Find function (see my mockup screenshot for a dark theme).
On the other hand, from a developer perspective, it may be easier and quicker to implement the current solution with the prefixes. The choice is at the developers' discretion.
Cheers,
Dave
That carat is from Qt, because that search dialog is a QComboBox, a combined button and popup list
Thanks for the note.
I suspected it was a generic GUI component from QT. Isn't there a way to add a button and a text field, but not a comboBox?
It is a minor issue in my opinion, but I did spent some time to figure out how the Find is supposed to work and the carat suggested functionality that is not there.
Cheers,
Dave
The carat was used to display previous search strings. It seems that it's not working anymore.
https://github.com/musescore/MuseScore/pull/2951
https://github.com/musescore/MuseScore/pull/2956
Fixed in branch master, commit e930dab93e
fix #105301: Solved the Find function bug; now the searchComboBox saves the searched values.
Fixed in branch master, commit b1550bec81
Merge pull request #2956 from RaphaelCojocaru/105301-FindBug
fix #105301: Solved the Find function bug; now the searchComboBox sav…
Fixed in branch 2.1, commit b0c288ea23
fix #105301: Solved the Find function bug; now the searchComboBox saves the searched values.
Testing the fix, and it seems search values are only saved if Return/Enter is pressed. By design, or an overlooked limitation?
This is the implementation. When Return/Enter is pressed, the searched value is saved in the searchbox and the search dialogue is closed.
Automatically closed -- issue fixed for 2 weeks with no activity.