What happened to SysStaff distanceUp and distanceDown?!
2.0.3 source link:
https://github.com/musescore/MuseScore/blob/2.0.3/libmscore/system.h#L48
The 2.0.3 class SysStaff looks like this:{syntaxhighlighter SPEC}
class SysStaff {
QRectF _bbox; ///< Bbox of StaffLines.
qreal _yOff; ///< offset of top staff line within bbox
qreal _distanceUp; ///< distance to previous staff
qreal _distanceDown; ///< distance to next staff
bool _show; ///< derived from Staff or false if empty {/syntaxhighlighter}
et cetera.
The current master has removed these variables and commented-out lines where the public properties for these variables are called, sometimes with a "TODO" in the comment.
I use SysStaff::distanceDown() and SysStaff::distanceUp() in my code, and now I have no substitute for it. What is the plan here? How should I be determining the distance between staves?
Comments
I can't answer that completely, but I can say that the current master includes code to automatically change staff distance. So that, for instance, having a note far below the staff wiill automatically push the next staff lower, saving you the trouble of adding and manualy adjusting a spacer. My guess is that spacers are disabled for now and would need to be reimplemented different, but that's just a guess. The current master is quite experimental. If you haven't already, see the mscore3.txt file in the main source folder for whatever documentation exists on the (very extensive!) changes that were recently merged.
In reply to I can't answer that by Marc Sabatella
I had not seen the mscore3.txt file, thanks for the info.
For me, I need the current distance, the same data that these previous methods/variables provided. But I'll check the developer's mailing list, as you mentioned in another post, and continue to update my own code so that it works.
My one concern is your statement that " The current master is quite experimental". Does that mean that it might all be rolled back and all my attempts to reconcile it with my code might be pointless? I assume the 5.6 part at least will continue, but there seem to be a lot of significant changes here.
In reply to I had not seen the by sideways
I doubt at this point it would be rolled back, but instead maybe think of it as "incomplete" - meaning it will probably still undergo fairly major changes yet in any effort to get everything working again. When you find the developers list, find and read the posts there relating to the recent changes to understand better what is going on.
In reply to I doubt at this point it by Marc Sabatella
Thanks for the confirmation of what I was imagining to be the state of MuseScore/master.
Hopefully, in the turmoil, I can add my Page Layout points/pixels as units option... I'm trying to work towards that anyway, so that my ongoing rebasing/updating is not so complex and far-flung. It really is a good idea, and there's a way to do it without messing with backwards compatibility. But that's another topic.
I also assume this means it's a good idea to rebase often and not get too far behind the curve.