Do Shape note misaligned with stem (Emmentaler) geetar • Nov 2, 2016 - 15:29 Reported version 2.1 Type Functional Severity S4 - Minor Status closed Project MuseScore Tags easy 2.0.3 / Win 7/10 The Do shape note is is not quite aligned with the bottom of its stem (see first note in the image below). This only seems to affect the Emmentaler font. Reply Comments [DELETED] 5 • Nov 7, 2016 - 20:36 This could be solved in the metadata.json file for the MScore font. It should be easy for a first timer! Reply vinayakvivek • Dec 19, 2016 - 07:44 Hi, I would like to try and fix this bug. This is my first contribution to musescore :), so need some help. Reply vinayakvivek • Dec 19, 2016 - 07:47 > ./fonts/mscore/metadata.json this file right? Reply Jojo-Schmitz • Dec 19, 2016 - 07:50 Should be, yes Reply vinayakvivek • Dec 20, 2016 - 06:21 http://pastebin.com/raw/CnyPFS85 Can you please explain what those "stemDownNE" and "stemUpSW" values represent? Reply [DELETED] 5 • Dec 20, 2016 - 06:39 You mean stemDownNW and stemUpSE See http://w3c.github.io/smufl/gitbook/specification/glyph-registration-not… Reply vinayakvivek • Dec 20, 2016 - 08:53 I have submitter a PR. Please review it.https://github.com/musescore/MuseScore/pull/2919 Reply Jojo-Schmitz • Dec 20, 2016 - 09:09 Status (old) active ⇒ patch (code needs review) You'd need to sign the CLA Reply Git Message • Dec 21, 2016 - 10:03 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit a8f42683dc fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler) Reply Git Message • Dec 21, 2016 - 10:03 Fixed in branch master, commit c65ab20689 Merge pull request #2919 from vinayakvivek/master fix #139641: Do Shape note misaligned with stem (Emmentaler) Reply Git Message • Dec 21, 2016 - 10:04 Fixed in branch 2.1, commit c65d050e35 fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler) Reply System Message • Jan 4, 2017 - 10:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply Isaac Weiss • Feb 22, 2017 - 22:23 Similar, subsequent issue: #176671: Slash notehead position needs adjusting Reply
[DELETED] 5 • Nov 7, 2016 - 20:36 This could be solved in the metadata.json file for the MScore font. It should be easy for a first timer! Reply
vinayakvivek • Dec 19, 2016 - 07:44 Hi, I would like to try and fix this bug. This is my first contribution to musescore :), so need some help. Reply
vinayakvivek • Dec 20, 2016 - 06:21 http://pastebin.com/raw/CnyPFS85 Can you please explain what those "stemDownNE" and "stemUpSW" values represent? Reply
[DELETED] 5 • Dec 20, 2016 - 06:39 You mean stemDownNW and stemUpSE See http://w3c.github.io/smufl/gitbook/specification/glyph-registration-not… Reply
vinayakvivek • Dec 20, 2016 - 08:53 I have submitter a PR. Please review it.https://github.com/musescore/MuseScore/pull/2919 Reply
Jojo-Schmitz • Dec 20, 2016 - 09:09 Status (old) active ⇒ patch (code needs review) You'd need to sign the CLA Reply
Git Message • Dec 21, 2016 - 10:03 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit a8f42683dc fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler) Reply
Git Message • Dec 21, 2016 - 10:03 Fixed in branch master, commit c65ab20689 Merge pull request #2919 from vinayakvivek/master fix #139641: Do Shape note misaligned with stem (Emmentaler) Reply
Git Message • Dec 21, 2016 - 10:04 Fixed in branch 2.1, commit c65d050e35 fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler) Reply
System Message • Jan 4, 2017 - 10:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Isaac Weiss • Feb 22, 2017 - 22:23 Similar, subsequent issue: #176671: Slash notehead position needs adjusting Reply
Comments
This could be solved in the metadata.json file for the MScore font. It should be easy for a first timer!
Hi, I would like to try and fix this bug. This is my first contribution to musescore :), so need some help.
> ./fonts/mscore/metadata.json
this file right?
Should be, yes
http://pastebin.com/raw/CnyPFS85
Can you please explain what those "stemDownNE" and "stemUpSW" values represent?
You mean stemDownNW and stemUpSE
See http://w3c.github.io/smufl/gitbook/specification/glyph-registration-not…
I have submitter a PR. Please review it.
https://github.com/musescore/MuseScore/pull/2919
You'd need to sign the CLA
Fixed in branch master, commit a8f42683dc
fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler)
Fixed in branch master, commit c65ab20689
Merge pull request #2919 from vinayakvivek/master
fix #139641: Do Shape note misaligned with stem (Emmentaler)
Fixed in branch 2.1, commit c65d050e35
fix #139641: Do Shape notes(quarter and half) misaligned with stem (Emmentaler)
Automatically closed -- issue fixed for 2 weeks with no activity.
Similar, subsequent issue: #176671: Slash notehead position needs adjusting