import volume from midi tracks
Choirs often use midi-files where one of the tracks has a higher volume than the others for practicing purposes. MuseScore currently ignores these volumes. See also this forum post: https://musescore.org/en/node/21534.
I have a patch ready that imports volumes from midi tracks and sets it on the first channel for the instrument that is created for the track. This is done only if a single volume control event occurs for the midi track, and that event occurs at the beginning of the track.
Do you think this is a viable approach?
Comments
Show the patch and we'll see...
Here you go. This is my first attempt at doing C++, so please forgive any stupid mistakes I might have made.
Better do a Pull Request on Github, see https://musescore.org/en/development.
The code looks OK, except for some superfluos braces maybe.
I have not checked whether it works though
I wanted some feedback on the approach before creating the pull request, but I can create the PR anyway, that's no problem.
.edit: created PR: https://github.com/musescore/MuseScore/pull/2974
It is easier to review and even test from there
Fixed in branch master, commit 7e65c70341
fix #165496: Import MIDI track volume
Import the volume of a MIDI track when that track contains a single
volume control event at tick 0.
Fixed in branch master, commit 101541c7f8
Merge pull request #2974 from NetForce1/165496-import-midi-track-volume
fix #165496: Import MIDI track volume
Fixed in branch 2.1, commit 68b98c5827
fix #165496: Import MIDI track volume
Automatically closed -- issue fixed for 2 weeks with no activity.