Crescendo plugin
Is the crescendo/diminuendo plugin described in http://musescore.org/en/project/crescendo-diminuendo-playback supposed to work with Musescore 1.2? I downloaded the zip file, unzipped it, put it in the plug in library, and when I started Musescore it appeared in the plugin menu. I used it as described in the above link, but the plugin menu turned into a white box, and Musescore hung, just giving me the whirling arrow. I closed Musescore, started it again, it asked if I wanted to restore the session, I said yes, but Musescore came up blank, with no score in it. I tried this twice with the same results.
I guess I can simulate it by putting dynamics in measure-by-measure. Is this the best/only way to do a diminuendo?
Comments
The plugin work fine for me. What OS are you using? Can you post a score and specific instructions to reproduce the problem you are seeing?
As for other ways of getting diminuendos to playback, instead of entering multiple dynamics and then hiding them, it is probably better to adjust note velocities directly via the Note Properties right click menu.
In reply to The plugin work fine for me. by Marc Sabatella
Here is a sample that acted just like I described, with one small difference. I had f from the palette marked on the first note and p on the last; invoking the plugin caused the session to hang as described, but this time the session restarted, but the p had disappeared and there was a small diminuendo below the staff. Redoing the diminuendo had the same effect. When I brought Musescore up again, this time the p and f were both there, but despite the small diminuendo sign, I can't hear any diminuendo: it sounds like all the notes are f except the last, which is p. I have W7 64b.
In reply to Here is a sample that acted by jcorelis
hangs for me too, WinXP SP3, MuseScore 1.2
Actually loops and on the following line:
while(!cursor.isChord()){cursor.next();}
So it fails to check for EOS
See also #13219: loops if last note of selection is last note of staff, and the workaround/fix is indeed to check for eos.
In reply to hangs for me too, WinXP SP3, by Jojo-Schmitz
Nice catch - I had probably seen the original report but forgotten. So, one should be able to fix this in one's own installation by editing the plugin directly (which I am doing for myself right now). Hopefully at some point it will get fixed in the repository as well.
BTW, there are two such loops in the code - one to find the beginning, one to find the end. I didn't study the code, but would assume that only the second needs to be fixed, and that it doesn't hurt to add the extra check to the first.
In reply to Nice catch - I had probably by Marc Sabatella
That's a good reason to put plugins code in a source management system such as GitHub.
In reply to Nice catch - I had probably by Marc Sabatella
I only changed the the first of the two and that fixed the problem. The 2nd is not prefixed by a cursor.next(), guess that is the reason.
I've attache a fixed version to the issue
In reply to I only changed the the first by Jojo-Schmitz
Yes, I do believe you are correct - it is the first that is the problem. The second occurs within the context of a for loop that already knows how many chords it is iterating over and thus stops on the last chord of the selection. The first is the one that is hunting for the end of the selection.
In reply to Yes, I do believe you are by Marc Sabatella
Bug isfixed now and available at http://musescore.org/en/project/crescendo-diminuendo-playback