mscore/revision.h should not be in git, as it is a generated file
Each time I do a git fetch upstream; git checkout master; git rebase upstream/master
I get an error regarding mscore/revision.h
having been changed and not committed or stashed.
Given that mscore/revision.h
is generated by make revision
, and that make release
already has revision
as a dependency, it seems to me that mscore/revision.h
should be removed from the git repository completely and added to .gitignore
instead.
Just building a fresh checkout without any midifications should not result in changes that need committing, stashing or undoing.
Cheers
Tony
Comments
Wouldn't this be better posted in the MuseScore Devloper mailing list?
In reply to Wouldn't this be better by ChurchOrganist
I didn't realize there was a mailing list; I thought there were just these forums.
I posted here because the category said "Bug Reports", although later I discovered the Issue Tracker too, and realised it should have been posted there. I'll do that today.
Still finding my way round the MuseScore community! :)
Tony
In reply to Mailing list? by TonyM-softins
The developer mailing list can be joined here: http://dev-list.musescore.org/
See https://github.com/musescore/MuseScore/pull/175
Edit: I withdrew my pull request in favour of https://github.com/musescore/MuseScore/pull/173
In reply to See by Jojo-Schmitz
I'm looking forward to making further contributions :)
In reply to Thanks! by TonyM-softins
This and yout other pull request just got merged.