MM rests include uncomplete measures

Isensee

• Sep 2, 2018 - 11:41

Reported version

2.3

Type

Functional

Severity

S4 - Minor

Status

closed

Regression

Workaround

Project

MuseScore

A score like

should look like

but presently looks like

This may be fixed by adding just two lines in layout.cpp, line 1991ff.:
static bool breakMultiMeasureRest(Measure* m) { if (m->breakMultiMeasureRest()) return true;


  if (m-&gt;repeatStart()
      || (m-&gt;prevMeasure() &amp;&amp; m-&gt;prevMeasure()-&gt;repeatEnd())
// add two lines:

          || (m->isIrregular())

          || (m->prevMeasure() && m->prevMeasure()->isIrregular())
      || (m-&gt;prevMeasure() &amp;&amp; (m-&gt;prevMeasure()-&gt;sectionBreak())))
        return true;

Attachment	Size
multiMeasureRests2.png	12.85 KB
multiMeasureRests1.png	11.63 KB
multiMeasureRests3.png	12.12 KB

Comments

Jojo-Schmitz

• Sep 2, 2018 - 12:28

Status (old)	active	⇒	patch (code needs review)
Status	active	⇒	PR created

Not a formal PR on github.com, but still a proposed patch...

Jojo-Schmitz

• Nov 20, 2018 - 17:08

Status	PR created	⇒	active
Regression		⇒	No
Workaround		⇒	No

no PR and "patch (code needs review)" is gone

Anatoly-os

• Nov 20, 2018 - 20:03

Status

active

⇒

PR created

let's keep the status for better tracking. Creating actual PR or manual applying changes is a matter of few movements :)

Jojo-Schmitz

• Nov 21, 2018 - 15:36

OK, so turning it into a PR: https://github.com/musescore/MuseScore/pull/4191

One thing I don't understand is why measure 4 is not marked as being irregular, while 1, 5 and 8 are (via that little blue - sign above staff)

Jojo-Schmitz

• Nov 24, 2018 - 18:39

Status

PR created

⇒

needs info

If I untick 'Exclude from measure count' on those 2 pickup measures, I get that 'bogus' result, but that is the same as in 2.x and as by design as far as I can see?
Strange though that the 'remainder' measure don't get included in the mm rest. But do when turning their half and quarter rest into a full measure rest.

Jojo-Schmitz

• Nov 24, 2018 - 20:20

Status

needs info

⇒

PR created

With that patch it is irrelevant whether 'Exclude from measure count' is ticked or not and also whether a full measure rest gets forced on an incomplete measures (vie Shift+Ctrl+Del), So we're gaining consistency, mm-rests now only span subsequent empty regular measures.