Pressing number after mouse click works for a different line in "Italian" styled tablature staff

• Dec 10, 2019 - 07:58
Reported version
3.3
Type
Functional
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore

To reproduce:
1) choose italian tabs in the instruments menu
2) enter the note input "N"
3) choose the lowest line of the tabs and press "0"
4) note will appear on the highest line

It makes typesetting directly in italian tabs very hard.

Comments

• Dec 10, 2019 - 08:40
Status active ⇒ needs info

I don't see an "Italian tabs" instrument in the list, are you sure it's called italian tabs for the instrument?

Reply

• Dec 10, 2019 - 08:56

There is a Tablature style, "Tab. 6-string Italian", available for e.g. Guitar and Lute (see the OP's username ;-)). But that note input going to the top line is not specific to it, happens with a 'normal' Tablature too

Reply

• Dec 10, 2019 - 09:05
Status needs info ⇒ active

I don't know if it's a bug: I have almost zero experience with tablature staff, but click on the 1st/2nd/3rd/4/5/6th line (from the bottom) and press a number, the number is attached to 6/5/4th/3rd/2nd/1st (also from the bottom) instead of also 1/2/3/4/5/6. This is aberrant to me, is this supposed to happen?

EDIT: Definitely not, "common" tablature works normally from 1st to 6th.

Reply

• Dec 10, 2019 - 09:11
Title Note input and mouse click work reversely ⇒ Pressing number after mouse click works for a different line in "italian" styled tablature staff

Reply

• Dec 10, 2019 - 14:43

It doesn't, because the function this PR changed, cmdAddFret(), only affects number pressing, whereas the function PR #5398 changed, noteValForPosition(), which is called after cmdAddFret(), affects both mouse clicking and number pressing. And that's exactly the reason to fix in this way, visualStringToPhys() for string number is also executed after number pressing, which shouldn't happen, so in cmdAddFret() we have to execute physStringToVisual() to pre-revert (what a word) the impact.

Reply

• Dec 10, 2019 - 14:48
Title Pressing number after mouse click works for a different line in "italian" styled tablature staff ⇒ Pressing number after mouse click works for a different line in "Italian" styled tablature staff

Reply

• Dec 24, 2019 - 11:56
Status PR created ⇒ fixed

Fixed in branch master, commit a349116dc1

_fix #298362: pressing number after mouse click works for a different line in "italian" styled tablature staff

Resolves: https://musescore.org/node/298362.

This is because the string number is reversed for number pressing (for upside-down tablature staves) while in fact it isn't needed. So a physStringToVisual() is called in this patch to eliminate the effect. See https://musescore.org/en/node/298362#comment-965223._

Reply

Fix version
3.4.0