Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results

• Aug 24, 2014 - 14:42
Type
Graphical (UI)
Severity
S4 - Minor
Status
closed
Project

Nightly, August 24 (57dd451) / Windows7

1) Open the score by default
2) Create a triplet -> select a quarter note -> Ctrl + 3
triolet.jpg

3) Fill with three A
2triolet.jpg
4) Exit note entry mode
5) Select the triplet
3triolet.jpg
6) Copy and Paste, or Repeat ("R" key)

Consequence: wrong result (:

triolet result.jpg

It "seems" that duolet, quartolet, 8 and 9 duolet works.

But failure again with quintuplet, sextuplet and septolet. See attachment.

others.jpg

Normal priority or critical? No crash, but very annoying result. So, critical for me (:

Attachment Size
triolet.jpg 7.72 KB
2triolet.jpg 6.18 KB
3triolet.jpg 7.46 KB
triolet result.jpg 7.33 KB
others.jpg 107.3 KB

Comments

Ok, Nigthly August 6 (88b44cd)

Wrong Nightly August 8 (5a616ff)

I continue my research (result only for triplet for the moment)

Title Copy-paste or repeat Triplet and others (quintolet...) displays wrong results Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results
Title Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results Copy-paste or repeat Triplet and others (quintolet...) displays wrong results

Thank you *so much* for that analysis! Makes it much simpler to pinpoint the problem.

Seems to be the following:

https://github.com/musescore/MuseScore/commit/107bbc9f2225cc76ff506a2c3…

If Bart is not around soon, I'll see if I can take a look. Would be great to have this fixed before beta!

Title Copy-paste or repeat Triplet and others (quintolet...) displays wrong results Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results
Title Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results Copy-paste or repeat Triplet and others (quintolet...) displays wrong results

I seem to be "it" :-)

Title Copy-paste or repeat Triplet and others (quintolet...) displays wrong results Copy-paste or repeat Triplet and others (quintuplet...) displays wrong results
Status (old) patch (code needs review) active

No, "default language" -> "Système" (this prevents me to change each time the preferences)

In French translation, it's quintuplet, yes (but I don't use it, you have understand)

Système.jpg

Attachment Size
Système.jpg 22.96 KB

We should stop here this digression, even it is interesting :)

The most important, by far, in this thread, is the comment # 11 of Marc.

Status (old) fixed active

Well, I'm not really sure that everything is solved with these triplets (:
This is to be verified.

1) when I create a triplet with Voice 2 (green), then I select it, to repeat with R, this R key do not work.
You must copy and paste (but the behavior seems uncertain at times? ) to succeed. And only then you can repeat with the R key.
2triplet.jpg

2) I can not merge two note heads (eighth triplet in Voice2, and dotted half note in voice 4) by using the Inspector to modify the note head of the eighth note. The result is two white note heads.
voice merged.jpg

3 voice merged.jpg

If I made a mistake somewhere, close the subject. If there is problem, thank you to open issues accordingly, because I don't know if it related or no at the first issue. Thanks.

Attachment Size
2triplet.jpg 6.65 KB
3 voice merged.jpg 13.43 KB
voice merged.jpg 15.13 KB

It seems unlikely that the fix I made would have disabled "R" behavior - I'll bet that hasn't worked for a while. But I'll look into why. It's related enough that I'll leave this issue open, but of course, much less critical than before.

The other issue could not possibly be related (? so I say now). I think it's that the code to merge noteheads only works for notes with opposite stems - you will see the same even if no tuplets are involved. If I can remember, I will file a feature request to make this work for notes with the same stem direction too, and then see if it can be done :-)

But for now, note that while you can't merge the noteheads by changing the eighth to a half note head, you can simply mark the eighth note head invisible. It will look on screen like it was the dotted half that became invisible and the eighth note is still there, but that's just because the invisible eighth is still there but greyed out. Print, or just turn off display of invisible elements, and you'll see it really is the half note.

I am agree. I have understood now regarding for the code which only works for merging noteheads when notes have opposite stems.

Simply I report now the issue, for not forget it, about the R key which doesn't work when repeating a triplet created in Voices 2, 3 ,4.