Lines still show when Inspector "Line visible" option is unticked and "Show Invisible" turned off

• Aug 9, 2015 - 16:38
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Apply a line from the palette to the score. Untick the "line visible" box in the Inspector. Now untick the menu option: view > show invisible.

Expected result: Line becomes invisible.
Actual result: The line remains greyed out.


Comments

There seems to be a difference in the element being set to invisible and the line being set to invisible, it works as expected when the element is set invisible, but not if the line is set to invisible.

Culprit seems to be libmscore/textline.cpp, TextLineSegment::draw(), where in line 83 the line Color gets set to gray if element or line arte set to invisible, but no care is taken to whether showInvisible is set to on or off. Adding a
else if (!tl->lineVisible() && !(score() && score()->showInvisible()))
color = Qt::transparent;
just before the test that resuts in the qray line color seems to fix this.

There seems to be a difference in the element being set to invisible and the line being set to invisible, it works as expected when the element is set invisible, but not if the line is set to invisible.

Culprit seems to be libmscore/textline.cpp, TextLineSegment::draw(), where in line 83 the line Color gets set to gray if element or line arte set to invisible, but no care is taken to whether showInvisible is set to on or off. Adding a
else if (!tl->lineVisible() && !(score() && score()->showInvisible()))
color = Qt::transparent;
just before the test that results in the qray line color seems to fix this.