Message 4: sf3 library - code improvement
Hello,
As the developer of the software Polyphone, one user asked me to work on the sf3 support. We exchanged a couple of emails and I'm now convinced of its benefits. By dividing by 10 the size of a soundfont and keeping most of its quality, it makes it easy to embed in a lot of applications (video games, mobile applications, ...). The idea is not new in that the format sf2pack (please note the "2") already exists for example, but it is now an open-source format which is promoted by a well-driven software with a pretty big community. Thus, I added the sf3 import / export.
The background being stated, I have several remarks and interrogations (most of them being technical). This message is part of a series comprising other messages.
Message 4: sf3 library - code improvement
(GitHub issue created here )
In order to make the sftools library easily integrated:
- the following dependencies can be avoided if non essential functions are removed: xml module of Qt, libsndfile;
- C++11 could be avoided by rewriting the initialization of a structure;
- warnings could be removed (memset(&p, sizeof(p), 0); / unused variables);
- a namespace is missing;
- readCompressedSample is dead code.