GSoC 2017 - Timeline Navigation - Weekly Report #12

Posted 7 years ago

Hey everyone!

This is my last weekly report for my GSoC project. This will include all the work from the past week. It includes my key accomplishments up to this point, the tasks that have given me trouble, and my plan for the next week.

Key accomplishments

-Pull Request finished!

-My second pull request has been merged and is ready to be tried out. A couple bugs have been found, but have been fixed by other developers.

-Handbook entry made

https://musescore.org/en/node/245526 Here is a link to the timeline handbook page. This holds all the interaction for the timeline.

Key tasks that stalled

Switching over to my school's internet has slowed down my work due to being throttled at 1.1MB/sec.

Tasks until the end

-Switch over to main palette

Currently, my code has hard coded colors instead of using the main palette. I will change that before I run out of time

-Clean up

Any strange or unused code I find I will remove and I will add any comments to help future developers.

Overall, I have had a great time working with MuseScore on this project. Everyone was very helpful and I enjoyed contributing to this wonderful software!

Thanks for reading!

Joshua Bonn

GitHub: https://github.com/JoshuaBonn1

(Current branch is https://github.com/JoshuaBonn1/MuseScore/tree/8-timeline-class )

IRC nick: JoshuaBonn1


Comments

Congrats! I've been busy for much of the last two weeks and haven't checked on things much. I'm a little surprised that there's a whole row dedicated for barlines. Wasn't the original idea to have them, well, on the barlines (the vertical cell separators in the grid)? That would be more efficient in terms of space and more natural, I think, to the eye scanning the grid. Was this found to be unfeasible for some reason?

Also, as you're making the final changes to the colors, I still strongly advocate for flopping the colored and gray sections for in and out of range cells.

And is it too late to get a meta row for page numbers, so this could really be the new Navigator?

In reply to by Isaac Weiss

Yes the original idea was to have the barlines on the timeline itself...it turns out that was a little too distracting. Then had repeat barlines share with jumps and markers...but that was too cluttered...so split off. And actually having barlines separate is useful because double barlines are often placed at measures that make sense for navigation.

I don't have a strong opinion about pages numbers...I remember there was a discussion about this...I can't remember the conclusion. But an extra row would work.

In reply to by ericfontainejazz

Here is the link to the original discussion: https://musescore.org/en/node/239351
There was never much of an agreement, but people liked some sort of mixture of the two ideas. I am personally for the meta row as A) it is easier for me to code :) and B) it is cleaner in my opinion. Especially since you can add and remove them as you wish. The idea of a large number overlay just seems messy compared to the current timeline design of everything being neatly inside their box.