Opening a midi that starts before the beginning of the clip causes crash
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
won't fix
Regression
Yes
Workaround
No
Project
1) Open a Midi that starts before "0" in the timeline
2) MuseScore will crash instantly.
Instead, there should be a couple of detectors that scan the Midi before attempting to open it. Try to check for potential crash-inducing properties. Out of bounds, etc.
Comments
Please provide a sample midi file
In reply to Please provide a sample midi… by Jojo-Schmitz
Here you go!
Works in MuseScore 1.3 BTW, it just imports it
But crashes already in 2.3.2, so a 2.x regression of sorts
I can't seem to get a decent stack trace, it just crashes in a debugger (QtCreator/MinGW) too
This is an incorrect midifile. It doesn't open in Sekaiju or Cakewalk either.
I was able to open it with an old software. In it, it is seen that it started from the 23302nd measure.
It does open in Windows Media Player though (but doesn't play)
Still shouldn't crash.
And as mentioned MuseScore 1.3 just imports it
In reply to It does open in Windows… by Jojo-Schmitz
I think if you wait 12hrs 56mins 42sec Windows MediaPlayer will play the file.
No, if I hit 'play' it comes back immediatelly
In reply to No, if I hit 'play' it comes… by Jojo-Schmitz
I replied according to what you said: It does open in Windows Media Player though (but doesn't play)
As said: It does open, but does not play. Even if I woule wait 12hrs 56mins 42sec , it would not play, as Windows Media Play stops right away, as seen by the changes of the icon for Play and Pause. I can't 'fast forward' either.
See https://github.com/musescore/MuseScore/pull/9081
No more fixes for 3.x
It is part of https://github.com/musescore/MuseScore/pull/9000 though, so you could use the artifacts of that