Untranslated strings, from Qt

• Aug 10, 2017 - 11:32
Reported version
2.1
Type
Wording/Translation
Severity
S4 - Minor
Status
closed
Regression
No
Workaround
No
Project
MuseScore

In the color dialog (you get there via Inspecte/Element/Color) there is an untranslated (and untranslatable) string "Pick Screen Color":
colorpicker.png
This string is not in MuseScore's code, it seems to stem directly from Qt, but is not in any of the qt*.ts files we distribute.

A quick search in my Qt installation seems to indicate that this string is in qtbase_*.{ts,qm},

The other string, "Select Color" is found in our code, translatable and even translated into German, I just wasn't using the latest translation when producing the image...

Attachment Size
colorpicker.png 83.11 KB

Comments

• Aug 10, 2017 - 11:39

It would be helpful to compare the qt_XX.ts file from Qt 5.4 and 5.9 and the one we have on github in term of number of languages and translation completion. In case the Qt ones are better, let's remove the ts from MuseScore code base and deploy the Qt ones on install.

Reply

• Aug 10, 2017 - 11:54

The install package of Qt only has the .qm files (on Windows at least), so we'd need to get to the sources, to check on the qt_XX.ts, qtbase_XX.ts and possibly more files

Reply

• Aug 10, 2017 - 13:25
Title Untranslated string ⇒ Untranslated strings, from Qt

Looking at Qt 5.9.1 source: To replace our current qt_XX.{ts,qm} (36 languages), we'd need to grab and deploy all the {qt,qtbase,qtmultimedia,qtquick1,qtscript,qtxmlpatterns}_XX.{ts,qm} files, (26 languages, 117 *.qm files currently, in Qt 5.9.1, 25 languages, 81 files in Qt 5.4), preferably using wildcards, to benefit from futur additions.
So we'd lose 10 languages (el, eu, id, nb, nl, nl_BE, pt_BR, ro, tr, vi) in master, 11 in 2.x (+bg, although we don't deploy it in master either), but gain not having to deal with Qt translations anymore.
We could also just keep those 10 qt_XX.{ts,qm} files only we have (and/or send them upstream for Qt to include them?), and maybe even update them from from the Qt sources

In a README I found:
See http://wiki.qt.io/Qt_Localization for information on how to contribute translations.

Reply

• Aug 14, 2017 - 16:43
Status (old) patch (code needs review) ⇒ fixed
Status ⇒ fixed

Fixed in branch master, commit 41b7906b2b

Fix #243516: Untranslated strings, from Qt

Remove all Qt translations from the MuseScore repository
that are also part of Qt 5.4 and later, and deploy Qt's instead.
Also , as a side effect, deploy our Bulgarian translation for Qt
(seems a day one ommision and not needed for Qt-5.9.1 and later)

Simplify the whole process for adding languages and running lupdate

Should be good for master and 2.2

Reply

• Aug 14, 2017 - 17:04

Fixed in branch 2.2, commit d1b606e03c

Fix #243516: Untranslated strings, from Qt

Remove all Qt translations from the MuseScore repository
that are also part of Qt 5.4 and later, and deploy Qt's instead.
Also , as a side effect, deploy our Bulgarian translation for Qt
(seems a day one ommision and not needed for Qt-5.9.1 and later)

Simplify the whole process for adding languages and running lupdate

Should be good for master and 2.2

Reply