Multi-Measure Rests and Measure Repeats display below the staff on single-line staffs
image on 3.0 dev 7f9585a:
image on 2.0.3 release:
Notice that in both versions the repeat measure symbol is displayed below the staff. The multi-measure rest somehow got offset incorrectly in 3.0.0.
Note that the definition of Staff::height() changed on Jun 19, 2014 with 7e4c70a such that a single line staff changed from 0 to having the same height as a two-line staff. It doesn't look like the 3.0 code for mm-rest and measure repeat is aware of this definition. Anyway, as I was implementing #10220: Add a two and four measure (multi-measure) repeat sign with playback I had already fixed this issue for single measure repeat, but I guess I will add the the PR the code for MMRests as well.
Comments
I fixed in my PR branch for #21649: [MusicXML] Repeat measure sign not exported or imported + #10220: Add a two and four measure (multi-measure) repeat sign with playback with the following commit:
https://github.com/ericfont/MuseScore/commit/b74c6d479e6abdcd82ebc135be…
so now looks like:
I'm marking this issue as tentatively "code needs review" even though the rest of the PR isn't complete. I'll eventually squash this commit into that PR.
Eric, the status of the https://github.com/musescore/MuseScore/pull/2859 is still In Progress for years :) What do you think is the best way to keep working on it?
At the very least a rebase is needed, and fixing the failing mtests
In reply to Eric, the status of the… by Anatoly-os
I need someone in authority (like lasconic or one of you) to say that when writing the MusicXML file, don't have to include repeated musical elements inside the measures of the multi-measure repeat. That is what was holding back that other PR.
See http://usermanuals.musicxml.com/MusicXML/Content/CT-MusicXML-measure-re…
The measure-repeat type is used for both single and multiple measure repeats. The text of the element indicates the number of measures to be repeated in a single pattern. Both the start and the stop of the measure-repeat must be specified. The text of the element is ignored when the type is stop. The measure-repeat element specifies a notation style for repetitions. The actual music being repeated needs to be repeated within the MusicXML file. This element specifies the notation that indicates the repeat.
yes, that is the quote from the specs that is holding my pr back. It is a bit vague. I interpreted it to mean that I had to duplicate the elements that are repeated into the multi-measure repeat measures. I did that by refactoring the MusicXML output code such that it looked back at previous measures to copy the elements. But maybe that message isn't actually saying need to duplicate the elements. Maybe it just means that the elements have to be included once in the MusicXML file...in their original measure.
Also unfortunately I don't have any authoritative MusicXML files with multi-measure repeats to compare against and for accurate test files.
I wonder if I should separate the non-MusicXML part out from the PR, so don't get held back by that one sentence in the MusicXML specs.
Well I've asked MusicXML github project to clarify that sentence: https://github.com/w3c/musicxml/issues/254 ...then I can proceed.
The child of #271331: [EPIC] Positioning, symbols, notation related issues
PR had been closed ages ago
BTW: the issue against / question for the MusicXML folks has been closed / answered / fixed too