MusicXML import: no barlines when using <staff-lines> property
Hello
When there is a staff-lines in musicXML, the import does not display the barlines.
The issue appears on Windows and OSX.
Enclosed examples of musicXml files :
- issue with staff-lines (staff-line=2 or 5)
- ok without staff-lines
detail of the difference betwwen the two xml files :
<staff-details> <staff-lines>5</staff-lines> </staff-details>
The value of staff-lines does not matter, according the two test files (one with staff-lines=2, one with staff-lines=5
OS: OS X 10.13, Arch.: x86_64, MuseScore version (64-bit): 2.2.1, revision: 51b8386
OS: Windows , Arch.: x86_64, MuseScore version (32-bit): 2.2.1, revision: 51b8386
Use-case
File/Import Musicxml ( with staff-lines) : bar-measure are not visible (enclosure pb_with_staff_lines_x.xml )
File/Import Musicxml (without staff-lines) : bar-measure are well displayed (enclosure ok_without_staff_lines.xml)
Thank you for your support
Franck Revolle
www.expresseur.com
Attachment | Size |
---|---|
ok_without_staff_lines.xml | 2.93 KB |
pb_with_staff_lines_2.xml | 2.99 KB |
pb_with_staff_lines_5.xml | 2.99 KB |
Comments
Interestingly, it works in master.
In reply to Interestingly, it works in… by [DELETED] 5
Is it possible to have a patch Or a workaround to correct this issue ? :
- ussing the script : a commnad to force the display of the meausure bar
- using another tag in musicXML
- a temporary patch I can recommend to use
I use MuseScore, with command line, to display the music in my freeware www.expresseur.com , using musicXML format.
This issue is "critical" for my software ( no barline kills the readibility .. )
Thank you in advance
Franck
Workaround: use MuseScore 2.1 (possible a PortableApp), as that version is not affected.
So we're looking at a regression here
Problem reproduces for me (current 2.3). It also shows up when opening test file mtest/musicxml/io/testDrumset2.xml in the GUI, but strangely enough not when running iotest.
Problem seems to disappear when removing the line:
score->staff(staffIdx)->setBarLineTo(0); // default
from function setStaffLines() in file importmxmlpass2.cpp.
Impact of this change still to be determined.
Esp. as the same code is in master too and doesn't seem to cause the issue there?!?
This was added here https://github.com/musescore/MuseScore/commit/a02dbcb6e2bdb3619a1f40188… and a cherry pick of master https://github.com/musescore/MuseScore/pull/3345
I would remove this line, but @lvinken, I will let you have a closer look !
Jojo,
the simple explanation for the different behaviour between 2.x and master is that bar line span handling was changed in master but not in 2.x. As a result, the line "score->staff(staffIdx)->setBarLineTo(0);" is correct only in master. Due to the cherry-pick this line was incorrectly put into 2.x, causing the regression.
Nicolas,
I have submitted a 2.3 specific pull request: https://github.com/musescore/MuseScore/pull/3652. Please do not copy to master.
Regards, Leon.
Fixed in branch 2.3, commit e608cd4ef2
fix #271840 (2.3 only)
Fixed in branch 2.3, commit 3b4a597289
Merge pull request #3652 from lvinken/fix-271840
fix #271840 (2.3 only)
Thank you
Hope 2.3 will come soon :-)
Franck
You can try the development builds right away, esp. those for the 2.3 branch, without much risk.
It works fine with 2.3 branch.
Than you very much
Franck
Automatically closed -- issue fixed for 2 weeks with no activity.