The text in pianolevelsfilter.cpp does not specify units, so I've changed the text to include units. I also changed the math for the Length offset to use fractions of a whole note instead of the older deprectaed ticks system.
This issue has grown from what it first was. It is now an upgrade for the Piano Levels Filter, so that it can use Fractions instead of the old ticks measurements. I can't seem to update the issue here, but I've changed the description on the PR.
_fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system
Upgrading the Piano Levels Filter system to use Fration of whole note instead of ticks.
Selecting a single note now updates the Set box.
Changes to tooltip descriptions of filters.
Can now use negative values for specifying note lengths._
Comments
https://github.com/musescore/MuseScore/pull/6040
blackears, could you please provide more info about what specific text or instructions are vague and what they could be replaced with. Thanks
https://github.com/musescore/MuseScore/pull/6041
In reply to blackears, could you please… by FreshDrPepper
The text in pianolevelsfilter.cpp does not specify units, so I've changed the text to include units. I also changed the math for the Length offset to use fractions of a whole note instead of the older deprectaed ticks system.
https://github.com/musescore/MuseScore/pull/6043
This issue has grown from what it first was. It is now an upgrade for the Piano Levels Filter, so that it can use Fractions instead of the old ticks measurements. I can't seem to update the issue here, but I've changed the description on the PR.
Fixed in branch 3.x, commit e6ec376a07
_fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system
Upgrading the Piano Levels Filter system to use Fration of whole note instead of ticks.
Selecting a single note now updates the Set box.
Changes to tooltip descriptions of filters.
Can now use negative values for specifying note lengths._
Fixed in branch 3.x, commit 853cc3cb11
_Merge pull request #6043 from blackears/304906-improve-pre-tooltips-3
fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system_
still needed for master
Fixed in branch master, commit fe006ce09d
_Merge pull request #6043 from blackears/304906-improve-pre-tooltips-3
fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system_
Automatically closed -- issue fixed for 2 weeks with no activity.