[Feature Request] pitch up/down feature in the piano roll. luyikai • Mar 3, 2016 - 06:17 Type Graphical (UI) Severity S5 - Suggestion Status closed Project MuseScore I think it's cool if we can change selected notes' pitch by clicking up-key and down-key in the piano roll. I already wrote code so I'm going to create a pull request now. Reply Comments luyikai • Mar 3, 2016 - 06:46 Selection in the piano works only on notes. Not "NoteEvent"s for (QGraphicsItem* item : items) { if (item->type() == PianoItemType) { Note* note = static_cast(item)->note(); _score->select(note, SelectType::ADD, 0); } } } So technically, if selection works only on notes, we can change selected notes' pitch. Reply luyikai • Mar 3, 2016 - 06:49 https://github.com/musescore/MuseScore/pull/2420 Reply luyikai • Mar 3, 2016 - 07:29 Reply Jojo-Schmitz • Mar 3, 2016 - 17:24 Status (old) active ⇒ patch (code needs review) Reply Git Message • Mar 25, 2016 - 12:05 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 66179c251c Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply Git Message • Mar 25, 2016 - 12:05 Fixed in branch master, commit e332d5656e Merge pull request #2420 from luyikei/pitch-change-pianoroll Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply Git Message • Mar 25, 2016 - 12:07 Fixed in branch 2.0.3, commit 4e1e621765 Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply System Message • Apr 8, 2016 - 13:10 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
luyikai • Mar 3, 2016 - 06:46 Selection in the piano works only on notes. Not "NoteEvent"s for (QGraphicsItem* item : items) { if (item->type() == PianoItemType) { Note* note = static_cast(item)->note(); _score->select(note, SelectType::ADD, 0); } } } So technically, if selection works only on notes, we can change selected notes' pitch. Reply
Git Message • Mar 25, 2016 - 12:05 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 66179c251c Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply
Git Message • Mar 25, 2016 - 12:05 Fixed in branch master, commit e332d5656e Merge pull request #2420 from luyikei/pitch-change-pianoroll Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply
Git Message • Mar 25, 2016 - 12:07 Fixed in branch 2.0.3, commit 4e1e621765 Fix #100536 [Feature Request] pitch up/down feature in the piano roll. Reply
System Message • Apr 8, 2016 - 13:10 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Selection in the piano works only on notes. Not "NoteEvent"s
for (QGraphicsItem* item : items) {
if (item->type() == PianoItemType) {
Note* note = static_cast(item)->note();
_score->select(note, SelectType::ADD, 0);
}
}
}
So technically, if selection works only on notes, we can change selected notes' pitch.
https://github.com/musescore/MuseScore/pull/2420
Fixed in branch master, commit 66179c251c
Fix #100536 [Feature Request] pitch up/down feature in the piano roll.
Fixed in branch master, commit e332d5656e
Merge pull request #2420 from luyikei/pitch-change-pianoroll
Fix #100536 [Feature Request] pitch up/down feature in the piano roll.
Fixed in branch 2.0.3, commit 4e1e621765
Fix #100536 [Feature Request] pitch up/down feature in the piano roll.
Automatically closed -- issue fixed for 2 weeks with no activity.