Frame gap in imported score lost on save
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
3.0.1, Windows 10
1) load attached created with default settings in 2.x - note the 0sp gap between the two frames, which was the default in 2.3.2
2) save
3) reload
Result: the 0sp gap between frames has turned into 14sp, which is the default in MuseScore 3. That's 7sp for top frame bottom gap, 7sp for bottom frame top gap. Independent of questions about why the change in defaults happened, it's bad that we imported correctly but then lost the info. It appears to me we are not writing the tag at all, I guess because 0sp is the default value in 2.3.2, but we need to check against the 3.0 default.
If you then manually change the relevant gaps back to 0 and resave, it sticks this time, but that's not a convenient workaround to lost info.
Attachment | Size |
---|---|
frame-gap-2.mscz | 4.62 KB |
Comments
Hmmm, I (probably) caused this in this commit. Let me take a look at it.
It looks exactly the same to me in MS2 and 3, albeit with slight padding differences due to the way we do that now in MS3.
v2:
v3 (latest master, Feb 6th):
So, in fact, it seems like I fixed this issue in the aforementioned commit, which is weird since you filed this issue about 8 days after the PR was merged. If you mean that the values appear different in the inspector, then that's how it's meant to be. In 2.x, a 7sp top and/or bottom gap for a frame adjacent to a stave was implied, but in 3.x it isn't, so we have to read it in to make the scores look the same from 2.x.
https://github.com/musescore/MuseScore/pull/4651
Fixed in branch master, commit b204134d37
fix #282507: imported frame gap of 0 lost on save
Fixed in branch master, commit 21e5a7c967
_Merge pull request #4651 from jthistle/282507-imported-framegap-lost-on-save
fix #282507: imported frame gap of 0 lost on save_
Fixed in branch 3.0.5, commit 5749fe8580
_Merge pull request #4651 from jthistle/282507-imported-framegap-lost-on-save
fix #282507: imported frame gap of 0 lost on save_
Automatically closed -- issue fixed for 2 weeks with no activity.