I don't think this issue should indicate any scheduling. It's intended to give an overview of the issues relating to the particular feature, the fretboard diagram.
I don't know what Issue Tracking engine musescore uses, and since it sounded enough like JIRA, I made a guess.
But back to the point, I received a notification about this post, and I assume it's because I was involved in some of the linked issues. So I was trying to understand what's going on here.
As the list of linked issues has grown since this morning, it appears that someone is compiling a list of all fretboard related issues, perhaps in preparation for taking on the challenge.
Epic issues on MuseScore.org are designed to group related issues together. It seems their main purpose is to help someone trying to fix one issue to see the bigger picture of other issues that should be addressed at the same time.
Just a note, I'm going to look at fixing a fair few of these bugs over the next few weeks. This will require a fairly large reorganisation and refactor of the fretboard system, but once I'm done, we should have partial barres, multiple barrels, and less buggy behaviour. Sound good?
While you're in there perhaps you could take a look at the other Fretboard Diagram issues that were opened and tackle them all at once? I'm sure that would make you very popular :-)
Nice! Correct me if I'm wrong, but these are the ones that aren't bugs because of the fretboard design implementation, but rather for other reasons? Especially that open string one, that's just a one line change iirc ;)
Having taken a look at the other ones, mostly to do with barres, I've come to the conclusion that a refactor is needed to fix these issues. Would you agree? If so, I'm going to try and a refactor.
Sounds great! Maybe it is too much to ask but, is there any possibilities that in some moment (not so far) muse will be able to transport the fretboard diagrams as it does with the chord names?
Comments
Does this post indicate that all the linked JIRA are fixed in this EPIC? Or perhaps slated for fixing?
JIRA is a different issue tracking system, right?
I don't think this issue should indicate any scheduling. It's intended to give an overview of the issues relating to the particular feature, the fretboard diagram.
I don't know what Issue Tracking engine musescore uses, and since it sounded enough like JIRA, I made a guess.
But back to the point, I received a notification about this post, and I assume it's because I was involved in some of the linked issues. So I was trying to understand what's going on here.
As the list of linked issues has grown since this morning, it appears that someone is compiling a list of all fretboard related issues, perhaps in preparation for taking on the challenge.
So that's good news!
In reply to I don't know what Issue… by reggoboy
Epic issues on MuseScore.org are designed to group related issues together. It seems their main purpose is to help someone trying to fix one issue to see the bigger picture of other issues that should be addressed at the same time.
In reply to Epic issues on MuseScore.org… by mike320
Excellent. In JIRA they might all be tagged with the same “Component”.
I will say again that MuseScore is such a beautifully designed product.
If help is needed helping to design or test the fret diagrams, it matters a lot to me and I’d love to help.
Made this an epic issue.
Just a note, I'm going to look at fixing a fair few of these bugs over the next few weeks. This will require a fairly large reorganisation and refactor of the fretboard system, but once I'm done, we should have partial barres, multiple barrels, and less buggy behaviour. Sound good?
+1.
Fantastic!
While you're in there perhaps you could take a look at the other Fretboard Diagram issues that were opened and tackle them all at once? I'm sure that would make you very popular :-)
I have also started looking at fixing some of these bugs. This is what I have so far: https://github.com/mattmcclinch/MuseScore/commit/86253bd
It fixes #283679: Fretboard diagrams: symbols on top of diagram, and position number do not resize when scaling is changed, #280575: Copy&Paste Fretboard diagram’s number is mirrored., and #283452: Fretboard Diagrams: open string symbol persists even when a finger dot is applied.
Nice! Correct me if I'm wrong, but these are the ones that aren't bugs because of the fretboard design implementation, but rather for other reasons? Especially that open string one, that's just a one line change iirc ;)
Having taken a look at the other ones, mostly to do with barres, I've come to the conclusion that a refactor is needed to fix these issues. Would you agree? If so, I'm going to try and a refactor.
In reply to Nice! Correct me if I'm… by TheOtherJThistle
Sounds great! Maybe it is too much to ask but, is there any possibilities that in some moment (not so far) muse will be able to transport the fretboard diagrams as it does with the chord names?
Just to let everyone know - my refactor is in progress. I am pushing my changes to my fret-refactor branch here: https://github.com/jthistle/MuseScore/tree/fret-refactor
https://github.com/musescore/MuseScore/pull/4785
This pretty much fixes the entire epic, save for the scaling issue and the fret offset number flipping issue.
#286183: Fret number in fretboard diagram can not be saved was reported today.
Any update on https://musescore.org/en/node/286183?
As you can see yourself #286183: Fret number in fretboard diagram can not be saved is still waiting to get merged
Edit: it has been and is in MuseScore 3.1
In reply to Excellent. In JIRA they… by reggoboy
JIRA is a brilliant issue tracking system. But this one here on musescore.org is already enough.