Workspace reset to Basic

• Oct 7, 2020 - 17:19
Reported version
3.5
Priority
P0 - Critical
Type
Functional
Frequency
Few
Severity
S2 - Critical
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project

In current 3.5.1 builds, if you create or change to a custom workspace, the workspace internally is set to basis.
Either the dropdown or the View / Toolbars menu will report current workspace is Basic, and quit/restart will change you to basic workspace. This is at least true if using the default language, it could be that things work better using a translated UI. The problem is very likely related to https://github.com/musescore/MuseScore/pull/6535; I think the translatableName is probably null here.

Possible solutions if my guess is right:

  • set translatable name explicitly to name if null, probably in changeWorkspace
  • check for null translatableName every time we use it and fallback to name
  • change definition of translatableName to do that check & fallback
  • revert that PR, as the bug it fixed was much less critical (only affecting language changes, not every workspace change and every program start)

I believe this to be a showstopper must fix for 3.5.1


Comments

Frequency Once Few

Permanentely revert to basic Workspace after close/Open MuseScore.
In 3.5.1 OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.5.1.291292197, revision: daa5fb7
And latest Dev Nightly Build OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.5.0.14162, revision: 00568f0
Language set to French

Title Custom workspace reset to Basic Workspace reset to Basic

Confirmed, Switching workspace from Basic to Advanced (Language set to System, which for me is German), stopping and restarting MuseScore and I'm bat to Basic, so no custom workspace needed.

Workaround Yes No

I don't see a workaround? Other than either coping with the Basic workspace of switching after every start of MuseScore, does that count?

Interestingly it works for me when changing from System (which really is Deutsch) to English (US).
But does not when changing to Deutsch, not System.

We should revert that anyway, reopen that one and close this one. I just changed to Spanish and my workspace changed to Basic. Using 3.5.1.

FWIW, I did try changing my language to English GB and I still saw the same bug. I started to try a fix of adding a setTranslatableName call, but I got sidetracked with a build environment problem, and anyhow don't really know what I'm doing here with the translation-related code, so I do hope someone else can look.

As for the workaround, yes, it's change to the proper workspace each and every time you start MuseScore. Not really acceptable, which is why I think this is critical to fix before release, but anyhow, that's what we're stuck with otherwise.

For me, Advanced worked fine, but I only tested that in default translation. Only custom workspaces didn't stick.

One possibly related datapoint: even in 3.5 I did see an annoying bug where after a crash in a custom workspace, it would sometimes reload with that workspace messed up. Like, I have two different custom workspaces with different settings for toolbars etc, after a crash in one workspace, the next start would come up in that workspace but with the toolbar settings from the other workspace, or vice versa. So I'd have to customize the toolbar settings over again. Palette settings never seemed to be a problem, just toolbars. So probably not related, but anyhow, something about the confusion over which workspace I'm in seems similar. But again, that was with 3.5, which otherwise worked fine as far as switching workspaces goes.

Workaround Yes No

It doesn't matter which workspace I'm in, changing to a language besides system changes to Basic workspace. Changing from Spanish to System in the Advanced workspace retained system workspace. I really think reverting is a better situation. If it can get fixed properly before final release then that's good but the current situation is worse than what was fixed.

Last night, I couldn't work all night because of this problem.
I often go into preferences and usually change the sound (or midi) drivers for another one. I went crazy with it reverting to "Basic" every time I confirm the changes.

I entered the Musescore.org forum today just to post this issue. But first I checked if there was a reaction. Marc Sabatella (thanks to him) was faster than me. :)

Status fixed needs info

Are you sure this issue is really fixed? With OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.5.1.291292197, revision: daa5fb7, this issue is always here.
Even after desinstall/reinstall, or revert to factory settings. Whatever I do: change to Advanced workspace, or Add palettes from Basic workspace, or creating Custom workspace: after closing, when I reload, Basic workspace is back on.

Fix version
3.5.1