Double coda roadmap is wrong
Test case from Miré on the french forum: https://musescore.org/fr/node/269228
The file plays correctly in 2.1 but not in 2.2-dev
Attachment | Size |
---|---|
Test 2-1vs 2-2.mscz | 7.87 KB |
Test case from Miré on the french forum: https://musescore.org/fr/node/269228
The file plays correctly in 2.1 but not in 2.2-dev
Attachment | Size |
---|---|
Test 2-1vs 2-2.mscz | 7.87 KB |
Comments
The culprit is the new logic used to rewind the playbackCount upon jumping at https://github.com/musescore/MuseScore/blob/master/libmscore/repeatlist…
In this example it leads to measure 6 being rewound when taking the first jump; but because it isn't (re)played during that jump and holds the startRepeat for all following measures the playthrough after the 2nd jump isn't considered the 'final' playthrough of that repeating section. Therefor it ignores jump instructions.
I think the solution here is to only rewind measures from jumpTo up to playUntil and then from continueAt to currentMeasure. I still have to see that it doesn't break any of the other current tests and add the posted score as a new testscenario.
https://github.com/musescore/MuseScore/pull/3472
Should apply cleanly to 2.2 as well
Fixed in branch master, commit e274a4167a
fix #269378 Double Coda leads to not detecting 'final' playthrough after 2nd jump rewind logic
Waiting for cherry-pick to 2.2
Fixed in branch 2.2, commit 1d3a9d315b
fix #269378 Double Coda leads to not detecting 'final' playthrough after 2nd jump rewind logic
issue status not updated correctly, probably because Jojo and Git posted simultaneously
Automatically closed -- issue fixed for 2 weeks with no activity.