Image capture: auto-resize selects system break
Image capture: auto-resize selects and includes the system break:
I don't recall the previous version having this issue.
| Attachment | Size |
|---|---|
| In Church (Tchaikovsky) (Excerpt).mscz | 14.43 KB |
Do you still have an unanswered question? Please log in first to post your question.
Comments
If i rightclick on the blue selection and use "print mode", it saves the image without line breaks. (maybe i dont get the issue)
Previous versions behaved the same, all the way back to MuseScore 2 when the feature was introduced.
In reply to Previous versions behaved… by Marc Sabatella
I can't prove it, but I swear the most recent version(s) didn't include the system break. In any event, what would the purpose be for including the system break in the image, since it won't show when saving as Print Mode, yet leaves a bunch of unwanted blank space in the image at the top?
In reply to I can't prove it, but I… by darkstream
To me it's a bug, just saying, it's a not a new one :-) I guess some of the time you are using screenshot mode and MuseScore can't know which you'll want when doing the autorisze, but to me this is the wrong assumption.
In reply to To me it's a bug, just… by Marc Sabatella
Thanks for the clarification. Is this an issue on the list, or should I add it?
In reply to Thanks for the clarification… by darkstream
I don't think it is amd yes, there's such a list, see https://musescore.org/en/node/add/project_issue?pid=1236
In reply to To me it's a bug, just… by Marc Sabatella
I have two solutions for this, and I see no reason why they could not be combined.
The first solution is to add ElementType::LAYOUT_BREAK to the list of element types that return false for Element::isPrintable(). https://github.com/mattmcclinch/MuseScore/commit/3452fad
The second solution is to ignore invisible elements when calculating Page::tbbox(). For this solution to work on its own, LayoutBreak elements need to know that they are invisible. https://github.com/mattmcclinch/MuseScore/commit/96f6a40
Both Page::tbbox() and Element::isPrintable() were added specifically for the purpose of trimming whitespace from exported PNG images in order to implement the Auto-resize function for the image capture facility. https://github.com/musescore/MuseScore/commit/f430751
In reply to I have two solutions for… by mattmcclinch
Hmm, I wonder, we also have the View menu option to toggle display of unprintable items, I wonder why these don't agree? I can't remember if that option existed when I added trim code.
Anyhow, there are actually worse problems with the auto resize right now, it seems if you move the box it gets out of sync and future attempts to use the function get the positioned wrong. See #314437: Image capture: "Auto-resize to page" misbehaves. But also, there is #305451: Image capture selection moves out of sight. We should probably look at all of these together and try to really fix this.
In reply to Hmm, I wonder, we also have… by Marc Sabatella
#314437: Image capture: "Auto-resize to page" misbehaves is easily fixed by making sure to reset the offset of the image capture rectangle when auto-resizing. https://github.com/mattmcclinch/MuseScore/commit/5b33908
In reply to Hmm, I wonder, we also have… by Marc Sabatella
And #305451: Image capture selection moves out of sight is fixed by being sure to call the correct methods when dragging or resizing the image capture lasso. https://github.com/mattmcclinch/MuseScore/commit/82a8ac5
Thanks for #317018: Image capture: auto-resize selects system break