Change "note head" to "notehead" in UI
Recalling Barline or bar line? , we have a very similar inconsistency, highlighted at Noteheads in the Handbook. I'd like to correct this.
Recalling Barline or bar line? , we have a very similar inconsistency, highlighted at Noteheads in the Handbook. I'd like to correct this.
Comments
Incidentally, it appears https://musescore.org/en/handbook/noteheads does not point to https://musescore.org/en/handbook/noteheads-0.
The UI itself uses "note head" consistently from what I can see, and I think this is probably best, since there are places where we use "head" alone (eg, "Head group", "Head type", and "Mirror head" in Inspector). Is there somewhere you see it being shown as "notehead"? Maybe just the Handbook?
It seems there are two places "note head" is used in the UI (palette title and edit drumset dialog), plus one more in the shortcuts list, and never "notehead." But "notehead" is used exclusively in not just MuseScore's documentation, but also Finale's and Sibelius's (and presumably also everywhere in their respective software, but they don't have searchable source code).
https://github.com/musescore/MuseScore/pull/2415
Care to explain? :-)
Basically, there is some small opposition to the change, and also my PR failed to take all instances into account. See PR for full discussion.
It's still on my agenda, though, especially, after http://music.stackexchange.com/questions/42722/notehead-or-note-head.
Okay, thanks.
I think the StackExchange responses should settle the discussion. :-)
The discussion on StackExchange wasn't very thorough. No one bothered to notice the New Harvard Dictionary of Music using "note head", or LilyPond using it, or the Sonata music font using it, for instance. There really is a pretty strong precedent both ways. Not that there is anything *wrong* with changing which of the two valid spellings we use, but it is important to realize they really *are* both valid, so it's not a question of correcting an error in the code. More like, modifying the code to be consistent with the errors made during documentation, which is a bit weaker of a justification for creating extra work. Still, with a complete PR in place, and buy in from the translators, I have no problems with it.
Fixed in branch master, commit cdc82364e4
Fix #100396: change "note heads" to "noteheads"
See http://music.stackexchange.com/questions/42722/notehead-or-note-head
(also correct "fo" to "for" in comment)
Fixed in branch master, commit ba9ab8df9a
Merge pull request #2582 from ZackTheCardshark/100396-noteheads-terminology
Fix #100396: change "note heads" to "noteheads"
Fixed in branch 2.0.4, commit 74ac75b839
Fix #100396: change "note heads" to "noteheads"
See http://music.stackexchange.com/questions/42722/notehead-or-note-head
(also correct "fo" to "for" in comment)
Automatically closed -- issue fixed for 2 weeks with no activity.
Found 4 new or forgotten occurrences of "note head"
See https://github.com/musescore/MuseScore/pull/3319
I don't believe this applied cleanly to 2.2 too, there I've 'fixed' it via the translations on Transifex
Fixed in branch 2.2, commit 00b7d69e4d
fix #100396: Change 'note head' to 'notehead' in UI
Also fixed in master 5b4553b
Automatically closed -- issue fixed for 2 weeks with no activity.