Changing time signature crashes Musescore - consistently.

• Aug 1, 2022 - 20:14

Background: I'd done this piece in with four quarter notes to the bar. My tutor suggested I change it to eighth notes. I followed instructions to select All, Cut and Paste Half Duration. That seemed successful. But in my original piece some bars changed from 4/4 to 3/4. I can change it at the correct point to 3/4 or 6/8 but when I select the next bar and change the time sig back to 4/4 Musescore crashes and closes.
To reproduce
1) check bar 10 - it changes to 6/8
2) select bar 11. From the sidebar select time signature 4/4 or C. There's a short whirling icon then Musescore crashes.
This happens every time I try it.

Windows 10, Musescore v3.6

Attachment	Size
Romantic_film_theme var 007 change note values.mscz	21.73 KB

Comments

Jojo-Schmitz

• Aug 1, 2022 - 20:21

Confirmed. stack trace:

1 Ms::ScoreElement::isChord scoreElement.h 266 0x105c0e0
2 Ms::ChordRest::isGrace chordrest.cpp 915 0x96d3f2
3 Ms::ScoreRange::write range.cpp 721 0xb77014
4 Ms::Score::rewriteMeasures edit.cpp 557 0x97f2c8
5 Ms::Score::rewriteMeasures edit.cpp 620 0x97f7f1
6 Ms::Score::cmdAddTimeSig edit.cpp 860 0x980c26
7 Ms::Measure::drop measure.cpp 1546 0xa29608
8 Ms::applyDrop palette.cpp 484 0x6c48d7
9 Ms::Palette::applyPaletteElement palette.cpp 740 0x6c6258
10 Ms::UserPaletteController::applyPaletteElement paletteworkspace.cpp 579 0x507dd7
11 Ms::AbstractPaletteController::qt_static_metacall moc_paletteworkspace.cpp 287 0x5f4000
12 Ms::AbstractPaletteController::qt_metacall moc_paletteworkspace.cpp 339 0x5f41ec
13 Ms::UserPaletteController::qt_metacall moc_paletteworkspace.cpp 432 0x5f437d
14 QQmlObjectOrGadget::metacall(QMetaObject::Call, int, void * *) const 0x66255e90
15 CallMethod(QQmlObjectOrGadget const&, int, int, int, int *, QV4::ExecutionEngine *, QV4::CallData *, QMetaObject::Call) 0x661a0674
16 CallPrecise(QQmlObjectOrGadget const&, QQmlPropertyData const&, QV4::ExecutionEngine *, QV4::CallData *, QMetaObject::Call) 0x661a17a4
17 QV4::QObjectMethod::callInternal(QV4::Value const *, QV4::Value const *, int) const 0x661a2564
18 QV4::Moth::VME::interpret(QV4::CppStackFrame *, QV4::ExecutionEngine *, const char *) 0x661b3e78
19 QV4::Moth::VME::exec(QV4::CppStackFrame *, QV4::ExecutionEngine *) 0x661b6dff
20 QV4::Function::call(QV4::Value const *, QV4::Value const *, int, QV4::ExecutionContext const *) 0x66158fae
...

Jojo-Schmitz

• Aug 2, 2022 - 10:13

Looks like there is a problem with a slur (maybe some slur that is having a note it starts on but none it ends at). Removing all slurs (as I don't yet see which slur exactly might be the culprit) and then apply the time sig change doesn't crash.

Jojo-Schmitz

• Aug 2, 2022 - 10:17

Possible fix (prevents the crash):

diff --git a/libmscore/range.cpp b/libmscore/range.cpp
index 1b008ffe40..05f9f261f5 100644
--- a/libmscore/range.cpp
+++ b/libmscore/range.cpp
@@ -718,7 +718,7 @@ bool ScoreRange::write(Score* score, const Fraction& tick) const
                         }
                   else
                         s->setStartElement(0);
-                  if (slur->endCR()->isGrace()) {
+                  if (slur->endCR() && slur->endCR()->isGrace()) {
                         Chord* sc = slur->endChord();
                         int idx   = sc->graceIndex();
                         Chord* dc = toChord(score->findCR(s->tick2(), s->track2()));

Jojo-Schmitz

• Aug 2, 2022 - 10:26

Not just 3.6.2 crashes on that, latest master code (which will become MuseScore 4) does too.
And the (basically) same fix apparently does fix the crash there too:

diff --git a/src/engraving/libmscore/range.cpp b/src/engraving/libmscore/range.cpp
index ea74c62fa1..b778c5891c 100644
--- a/src/engraving/libmscore/range.cpp
+++ b/src/engraving/libmscore/range.cpp
@@ -742,7 +742,7 @@ bool ScoreRange::write(Score* score, const Fraction& tick) const
             } else {
                 s->setStartElement(0);
             }
-            if (slur->endCR()->isGrace()) {
+            if (slur->endCR() && slur->endCR()->isGrace()) {
                 Chord* sc = slur->endChord();
                 size_t idx = sc->graceIndex();
                 Chord* dc = toChord(score->findCR(s->tick2(), s->track2()));

cadiz1

• Aug 2, 2022 - 11:35

On the attached file, the crash is due to the slur that starts at measure 20, on the F (top instrument, ie piano), and goes on until measure 22 (over the 3/4 time signature, on the second beat, on the tied D)
Does not occur if the slur extends only on the first beat of this same measure
Reproducible from scratch.
See the GIF.

And on this file: TEST.mscz : crash by adding a 4/4 time signature to the second measure
And on this one: TEST1.mscz : crash by adding a 6/4 time signature, still in measure 2.

Jojo-Schmitz

• Aug 2, 2022 - 12:32

Thanks for the investigation!

My fix (see above) looses that slur (rather: those slurs, all 3, in Piano, Viola and Cello). Might not be good, even if better than crashing...

Better get this reported in the issue tracker

Jojo-Schmitz

• Aug 2, 2022 - 17:37

What the heck, see https://github.com/musescore/MuseScore/pull/12652

Jojo-Schmitz

• Mar 14, 2023 - 10:58

That PR doesn't seem to apply any more.

normanlamont

• Aug 2, 2022 - 21:26

For what it's worth on my file I removed all slurs and crescendos from the immediate vicinity of the change of time signature and it still crashes when I add a change of time signature.

Jojo-Schmitz

• Aug 2, 2022 - 21:41

It is the slurs at the next time sig change that are the problem

normanlamont

• Aug 5, 2022 - 11:55

Got it, thanks!

Claudio Riffero

• Mar 14, 2023 - 11:45

@cadiz1
Hi, I would like to know what software you use to make the GIF video. Thank you!

cadiz1

• Mar 15, 2023 - 16:52

Fastone Capture
( but it seems to me that it is rather optimized for Windows, to check)

Claudio Riffero

• Mar 30, 2023 - 10:39

@cadiz1
Grazie

cadiz1

• Mar 30, 2023 - 10:48

Oops... I wrote too quickly.
It's not Fastone Capture, but FastStone Capture.
Sorry.

Jojo-Schmitz

• Mar 14, 2023 - 10:57

Please check whether this still happens with 4.0.2
I can't reproduce it any longer with any of the score attached here
Should have been fixed by b444d36e, so actually in 4.0 Beta already