Cannot create 5/8 time signature

ef996b4

Hi. I was getting a ton of crashes while trying to get this to work. I first tried to edit the time signature in the inspector and then the time signature properties via the context menu. This created a number of very bad looking measures.

I was able to get things working by editing the measure properties separately, and separately editing the time signature.

It seems that editing the time signature in the inspector should modify the measure properties just like dropping a time signature on a measure does.

So, maybe the bug is that the measure properties are not updated when the time signature is edited.

Also, editing the measure properties doesn't always work. For example:

- add 3/8 time signature
- edit time signature in inspector to be 5/8
- edit global time signature in inspector to be 5/8
- select a different measure
- select the time signature again
- inspector reads 5 / 2 for global time sign, not what I set above
- reset global time sig to 5 / 8
- select away, and back to time sig
- inspector reports 25 / 8 for global time sig
- reset to 5/ 8 again
- select away and back again
- global time sig is now 5 / 8 (whew)
- inspect measure properties for this measure
- measure reads 3/8 (nominal and actual)
- change actual to 5 / 8 and click OK
- bring measure properties back up
- nominal is stil 3 / 8 (should it be 5/8)

At this point, the measure does behave as a 5/8 measure. I'm not sure what the actual v. nominal mean in the measure inspector.

I see there are items in the inspector which are display oriented, but the inspector also reflects values from the "Time Signature Properties" editor which should effect the underlying measures.

So, I believe the bug is that the "Time Signature Properties" window does not update the related measures to match the newly edited time signature. In addition, the "Time Signature Properties" window does not allow editing of the "Global Value" field, which is required when changing a 4/4 time sig to 5/4 for example. In that case the global is 1/1 but needs to be reset to 5/4.

The list of issues I've seen:

1. Changes made in the "Time Signature Properties" dialog (e.g., 4/4 to 5/4) do not update the related measure properties. I think this should have the same result as dragging a time signature onto a measure.
2. The "Time Signature Properties" window does not allow editing of the "Global Value", which is required e.g., in the case of 4/4 being changed to 5/4 (Global Value needs to change from 1/1 to 5/4)
3. When inspecting the Time Signature, changes can be made to the "time sig." values, but the same problem as #1 exists - the underlying measure properties are not updated.
4. The inspector *does* allow changing the "global time sig." AKA "Global Value" but it updates the model in a non-deterministic way (as far as I can tell). Changes to these fields are re-computed as various strange values - eventually leading to a crash of the application.

I've uploaded a couple of screen captures showing some of the unexpected behavior I'm seeing. Note in particular the "global sig" freaking out in the second video and being un-editable in both:

https://s3-us-west-1.amazonaws.com/musescore/timesig1.mov
https://s3-us-west-1.amazonaws.com/musescore/timesig2.mov